Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👌⌨️ Activate mypy for model package #1160

Closed
s-weigand opened this issue Nov 4, 2022 · 1 comment
Closed

👌⌨️ Activate mypy for model package #1160

s-weigand opened this issue Nov 4, 2022 · 1 comment
Assignees
@joernweissenborn
Labels
Type: Enhancement Feature requests

Comments

@s-weigand
Copy link
Member

s-weigand commented Nov 4, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

#1135 Changed the mypy setting to ignore all modules in the glotaran.model package.

Describe the solution you'd like

Removed the ignore section for glotaran.model in setup.cfg (see comment) and fix already discovered typing issues (see comment)
@s-weigand s-weigand added the Type: Enhancement Feature requests label Nov 4, 2022
@s-weigand s-weigand mentioned this issue Nov 4, 2022
Merged
5 tasks
@s-weigand
Copy link
Member Author

My bad forgot that we currently use opt in in the mypy config 🤦‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joernweissenborn joernweissenborn

Labels
Type: Enhancement Feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joernweissenborn @s-weigand