From 4d38e46258e11074d3cc737dd38bdd440597fd34 Mon Sep 17 00:00:00 2001 From: Sebastian Weigand Date: Thu, 26 Sep 2024 21:29:59 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=9A=87=F0=9F=97=91=EF=B8=8F=20Remove=20bi?= =?UTF-8?q?nder=20link=20and=20integrations=20(#300)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This PR removes the [binder](https://mybinder.org) and the integration to add a PR comment with a binder link, as well as the workflow that triggers a build on binder when a commit is pushed to main. The reason to remove binder is that it hasn't been working properly for many months (i.e. timeout when opening) and checking the link in the docs recently also started failing. --- .github/workflows/binder-on-pr.yml | 29 ---------------------------- .github/workflows/trigger-binder.yml | 15 -------------- README.md | 1 - 3 files changed, 45 deletions(-) delete mode 100644 .github/workflows/binder-on-pr.yml delete mode 100644 .github/workflows/trigger-binder.yml diff --git a/.github/workflows/binder-on-pr.yml b/.github/workflows/binder-on-pr.yml deleted file mode 100644 index d0c66881..00000000 --- a/.github/workflows/binder-on-pr.yml +++ /dev/null @@ -1,29 +0,0 @@ -# Reference https://mybinder.readthedocs.io/en/latest/howto/gh-actions-badges.html -name: Binder Badge -on: - pull_request_target: - types: [opened] - -permissions: - pull-requests: write - -jobs: - binder: - runs-on: ubuntu-latest - steps: - - name: comment on PR with Binder link - uses: actions/github-script@v7 - with: - github-token: ${{secrets.GITHUB_TOKEN}} - script: | - var PR_HEAD_USERREPO = process.env.PR_HEAD_USERREPO; - var PR_HEAD_REF = process.env.PR_HEAD_REF; - github.rest.issues.createComment({ - issue_number: context.issue.number, - owner: context.repo.owner, - repo: context.repo.repo, - body: `[![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/${PR_HEAD_USERREPO}/${PR_HEAD_REF}?urlpath=lab/tree/docs/source/notebooks) :point_left: Launch a binder notebook on branch _${PR_HEAD_USERREPO}/${PR_HEAD_REF}_` - }) - env: - PR_HEAD_REF: ${{ github.event.pull_request.head.ref }} - PR_HEAD_USERREPO: ${{ github.event.pull_request.head.repo.full_name }} diff --git a/.github/workflows/trigger-binder.yml b/.github/workflows/trigger-binder.yml deleted file mode 100644 index dd639bea..00000000 --- a/.github/workflows/trigger-binder.yml +++ /dev/null @@ -1,15 +0,0 @@ -name: "Trigger-Binder-build" -on: - push: - branches: - - main - workflow_dispatch: - -jobs: - trigger-binder-build: - runs-on: ubuntu-latest - steps: - - uses: s-weigand/trigger-mybinder-build@v1 - with: - target-repo: glotaran/pyglotaran-extras - target-state: main diff --git a/README.md b/README.md index 66cb9eb9..1003d75d 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,6 @@ [![Conda Version](https://img.shields.io/conda/vn/conda-forge/pyglotaran-extras.svg)](https://anaconda.org/conda-forge/pyglotaran-extras) [![Tests](https://github.com/glotaran/pyglotaran-extras/actions/workflows/test.yml/badge.svg)](https://github.com/glotaran/pyglotaran-extras/actions/workflows/test.yml) [![Documentation Status](https://readthedocs.org/projects/pyglotaran-extras/badge/?version=latest)](https://pyglotaran-extras.readthedocs.io/en/latest/?badge=latest) -[![Binder](https://static.mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/glotaran/pyglotaran-extras.git/main?urlpath=lab%2Ftree%2Fdocs%2Fsource%2Fnotebooks) [![Ruff](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/astral-sh/ruff/main/assets/badge/v2.json)](https://github.com/astral-sh/ruff) [![codecov](https://codecov.io/gh/glotaran/pyglotaran-extras/branch/main/graph/badge.svg?token=I6F412Y390)](https://codecov.io/gh/glotaran/pyglotaran-extras)