From e63208fefbda2877875de3bd8453c14482363561 Mon Sep 17 00:00:00 2001
From: Kevin Hunter Kesling <kevin@globus.org>
Date: Tue, 12 Nov 2024 23:18:31 -0500
Subject: [PATCH] Remove unused HTEX tests

These HTEX tests were temporarily skipped in good-faith, but the HTEX class is
now deprecated.  It will be removed completely in the near future, so remove
these now unused tests.
---
 compute_endpoint/tests/unit/test_htex.py | 93 +-----------------------
 1 file changed, 1 insertion(+), 92 deletions(-)

diff --git a/compute_endpoint/tests/unit/test_htex.py b/compute_endpoint/tests/unit/test_htex.py
index f32857b84..a2a83a567 100644
--- a/compute_endpoint/tests/unit/test_htex.py
+++ b/compute_endpoint/tests/unit/test_htex.py
@@ -14,7 +14,7 @@
 )
 from globus_compute_sdk.serialize import ComputeSerializer
 from pytest_mock import MockFixture
-from tests.utils import div_zero, double, ez_pack_function, kill_manager, try_assert
+from tests.utils import double, ez_pack_function, try_assert
 
 
 @pytest.fixture
@@ -37,97 +37,6 @@ def htex():
     # shutil.rmtree(tempdir, ignore_errors=True)
 
 
-@pytest.mark.skip("Skip until HTEX has been fixed up")
-def test_htex_submit_raw(htex, serde, task_uuid, ez_pack_task):
-    """Testing the HighThroughputExecutor/Engine"""
-    engine = htex
-
-    q = engine.results_passthrough
-    task_bytes = ez_pack_task(double, 3)
-
-    # HTEX doesn't give you a future back
-    engine.submit_raw(task_bytes)
-
-    # Confirm that the same result got back though the queue
-    for _i in range(3):
-        packed_result_q = q.get(timeout=5)
-        assert isinstance(
-            packed_result_q, bytes
-        ), "Expected bytes from the passthrough_q"
-
-        result = messagepack.unpack(packed_result_q)
-        # Handle a sneaky EPStatusReport that popped in ahead of the result
-        if isinstance(result, messagepack.message_types.EPStatusReport):
-            continue
-
-        # At this point the message should be the result
-        assert result.task_id == task_uuid
-
-        final_result = serde.deserialize(result.data)
-        assert final_result == 6, f"Expected 6, but got: {final_result}"
-        break
-
-
-@pytest.mark.skip("Skip until HTEX has been fixed up")
-def test_htex_submit_raw_exception(htex, task_uuid, ez_pack_task):
-    """Testing the HighThroughputExecutor/Engine with a remote side exception"""
-    engine = htex
-
-    q = engine.results_passthrough
-    task_bytes = ez_pack_task(div_zero, 3)
-    # HTEX doesn't give you a future back
-    engine.submit_raw(task_bytes)
-
-    # Confirm that the same result got back though the queue
-    for _i in range(3):
-        packed_result_q = q.get(timeout=5)
-        assert isinstance(
-            packed_result_q, bytes
-        ), "Expected bytes from the passthrough_q"
-
-        result = messagepack.unpack(packed_result_q)
-        # Handle a sneaky EPStatusReport that popped in ahead of the result
-        if isinstance(result, messagepack.message_types.EPStatusReport):
-            continue
-
-        # At this point the message should be the result
-        assert result.task_id == task_uuid
-        assert result.error_details
-        break
-
-
-@pytest.mark.skip("Skip until HTEX has been fixed up")
-def test_htex_manager_lost(htex, task_uuid, ez_pack_task):
-    """Testing the HighThroughputExecutor/Engine"""
-    engine = htex
-
-    q = engine.results_passthrough
-    task_bytes = ez_pack_task(kill_manager)
-
-    # HTEX doesn't give you a future back
-    engine.submit_raw(task_bytes)
-
-    # Confirm that the same result got back though the queue
-    for _i in range(10):
-        # We need a longer timeout to detect manager fail
-        packed_result_q = q.get(timeout=5)
-        assert isinstance(
-            packed_result_q, bytes
-        ), "Expected bytes from the passthrough_q"
-
-        result = messagepack.unpack(packed_result_q)
-        # Handle a sneaky EPStatusReport that popped in ahead of the result
-        if isinstance(result, messagepack.message_types.EPStatusReport):
-            continue
-
-        # At this point the message should be the result
-        assert result.task_id == task_uuid
-
-        assert result.error_details.code == "RemoteExecutionError"
-        assert "ManagerLost" in result.data
-        break
-
-
 def test_engine_submit_container_location(
     mocker: MockFixture, htex: HighThroughputEngine, serde: ComputeSerializer
 ):