Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support adr.yaml custom config at root of project #9

Open
Asenar opened this issue Oct 17, 2024 · 7 comments · Fixed by Bellangelo/phpadr#2
Open

support adr.yaml custom config at root of project #9

Asenar opened this issue Oct 17, 2024 · 7 comments · Fixed by Bellangelo/phpadr#2

Comments

@Asenar
Copy link

Asenar commented Oct 17, 2024

Like phpunit, phpcs, phpstan, rector and other tools, if a config file is present in the project directory, it's used instead of the default configuration.

I think this feature would be a good improvement for this tools

@Bellangelo
Copy link

Hi @Asenar, I am not sure if this project is still maintained. I have created an issue to ask this specific question #10 and also I have created a fork https://github.com/Bellangelo/phpadr.
If you want you can create the issue there as well and if this project is still maintained we can just sync the upstream.

@Asenar
Copy link
Author

Asenar commented Nov 29, 2024

Hi @Bellangelo , it seems you didn't enabled the issue tab on your fork

@Bellangelo
Copy link

@Asenar Sorry for the late reply. I totally missed your response. I have just enabled them.

@Bellangelo
Copy link

Hi again @Asenar, I have created a PR Bellangelo/phpadr#2 for your case. Could you please check?

@Asenar
Copy link
Author

Asenar commented Jan 15, 2025

Hi @Bellangelo,

It does not seems to works.

After composer update bellangelo/phpadr:1.0.1, my config adr.yml is still ignored and I have to add --config=adr.yml.

When I check the repo, I see AutoDiscoverConfig class, but I don't see where it's used. Maybe you forgot to use it in your src/Command/* ?

@Bellangelo
Copy link

@Asenar Didn't push all the commits.. silly mistake. In the v1.0.3 it should all be fixed. I have added extra tests to further test the auto-discovery in each command and also, a new Github Action was added to run PHPUnit on each push and every PR: https://github.com/Bellangelo/phpadr/blob/master/.github/workflows/quality-checks.yml

@Asenar
Copy link
Author

Asenar commented Jan 20, 2025

After update it seems to works now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants