[A2][Insecure go project] Fix the Hardcoded credentials vulnerability #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavocovas
requested changes
May 20, 2020
There was a problem hiding this comment.
Hey, @secampos. Your changes look good, and the hardcoded credentials vulnerability is mitigated! 🐼
However, I was not able to run the app from your branch. I got the following error from the mongo container:
/docker-entrypoint-initdb.d/mongo-init.sh: line 1: +mongo: command not found
Seems like every line in deployments/mongo-init.sh is prefixed with a + sign. Could you fix that?
|
Oops, I forgot to remove it. Thanks, @gustavocovas. |
gustavocovas
approved these changes
May 20, 2020
gustavocovas
added
the
mitigation solution 🔒
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution refers to which of the apps?
A2 - Insecure go project
What did you do to mitigate the vulnerability?
All the hardcoded credentials was removed and they was moved to the deployments folder. The viper was used to get the credentials in environment variables.