Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering empty text blocks #16

Closed
sprmn opened this issue May 1, 2017 · 3 comments
Closed

Rendering empty text blocks #16

sprmn opened this issue May 1, 2017 · 3 comments

Comments

@sprmn
Copy link

sprmn commented May 1, 2017

It appears empty text blocks (for instance due to line breaks) are not rendered. Am I correct?

I would happily submit a PR if there is no solution available yet. Is there any solution available?

@raphaelpor
Copy link
Contributor

Hi @sprmn!
We'll discuss it and reply soon.

Thanks for your feedback. :)

@Canedo
Copy link
Collaborator

Canedo commented Aug 6, 2017

Hey @sprmn !
We discuss internally and we think that empty blocks should not be rendered by default.

But it would be cool to have a boolean to handle that (with the default value as false), that could make it possible to render empty text blocks. This way we would keep it compatible with us and everybody that uses our project, but in certains scenarios you could just pass this flag as props to RNDraftJSRender and empty text blocks would be available to any usage.

We would love a PR like that if you are really interested.

Thank you and sorry for us being late to answer you.

@jayporta
Copy link

Sorry to post in a closed thread, but did anyone ever work on this? I'm also trying to get a double line break to render.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants