Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE-169] Removing In memory repository #183

Open
wants to merge 7 commits into
base: development
Choose a base branch
from
Open

[ISSUE-169] Removing In memory repository #183

wants to merge 7 commits into from

Conversation

NJavokhir
Copy link
Contributor

@NJavokhir NJavokhir commented Feb 3, 2025 •
edited
Loading

Test Cases Checklist

SECTION 1: RESOURCE SERVER (http://localhost:5001/)

  • Created a new user on the Layer8 Portal

SECTION 2: WE'VE GOT POEMS (http://localhost:5173/)

  • Login as 'tester', '1234'
  • Choose login with layer8
  • Logging in with the newly registered credentials from Section 1 succeeds in popup
  • User chooses to share their new "Username" & "Country" from the Layer8 Resource Server
  • Choose poems 1 - 3 works correctly

SECTION 3: IMSHARER (http://localhost:5174/)

  • Uploads an image works
  • Reload leads to instant reload (demonstrating proper caching)

This PR removes the in-memory repository implementation since it is no longer used. Additionally, all related commands in the Makefile have been deleted to clean up the codebase.

Acceptance Criteria:
Removed in-memory repo implementation
Deleted related Makefile commands
Verified no dependencies on the removed code

This cleanup improves maintainability and reduces unnecessary code.

@NJavokhir NJavokhir self-assigned this Feb 4, 2025
@NJavokhir NJavokhir changed the title Removing In memory repository frist step [ISSUE-169] Removing In memory repository frist step Feb 7, 2025
@NJavokhir NJavokhir marked this pull request as ready for review February 15, 2025 13:22
@NJavokhir NJavokhir linked an issue Feb 15, 2025 that may be closed by this pull request
Remove the in-memory repository #169
Open
@NJavokhir NJavokhir changed the title [ISSUE-169] Removing In memory repository frist step [ISSUE-169] Removing In memory repository Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@interestIngc interestIngc Awaiting requested review from interestIngc

Assignees

@NJavokhir NJavokhir

Labels
None yet
Projects
Layer8
Status: 👀 Validation and Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the in-memory repository
1 participant
@NJavokhir