Fix/auto detect wrong network #664
Open
+137
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marclupanc
requested changes
Nov 29, 2024
| @@ -135,7 +135,7 @@ | |||
| mask="#.##" | |||
| fill-mask="0" | |||
| reverse-fill-mask | |||
| :rules="[() => (usdAmount < 3 ? 'Minimum allowed budget is 3 USD' : true)]" | |||
| :rules="[() => (usdAmount < 0.01 ? 'Minimum allowed budget is 3 USD' : true)]" | |||
There was a problem hiding this comment.
Please set it back to 3 USD
| @@ -302,12 +302,13 @@ async function onProceedPaymentDialog(props) { | |||
| if (_currentPrompt.value) { | |||
| $q.loading.show() | |||
| if (!customWeb3modal.getAddress()) { | |||
| $q.notify({ type: 'negative', message: 'Please connect your wallet and try again' }) | |||
| $q.notify({ type: 'negative', message: ' please connect your wallet ' }) | |||
There was a problem hiding this comment.
Please use capital letters in the beggining of sentence :)
| @@ -346,7 +346,7 @@ function handleDeleteEntry(entryId, promptId) { | |||
| async function onProceedDepositFundDialog(props) { | |||
| //let's check if the entry already have valid payment.. | |||
| if (!customWeb3modal.getAddress()) { | |||
| $q.notify({ type: 'negative', message: 'Please connect your wallet and try again' }) | |||
| $q.notify({ type: 'negative', message: ' please connect your wallet ' }) | |||
There was a problem hiding this comment.
Please use capital letters in the beggining of sentence :)
| const result = await getEventsForCampaign(advertise.campaignCode) | ||
|
|
||
| if (result.status.includes('success')) { | ||
| $q.notify({ message: 'events retreived successfully ', type: 'positive' }) |
There was a problem hiding this comment.
Please use capital letters in the beggining of sentence :)
| await _completeAdvertise(advertise) | ||
| } | ||
| if (!customWeb3modal.getAddress()) { | ||
| $q.notify({ type: 'negative', message: ' please connect your wallet ' }) |
There was a problem hiding this comment.
Please use capital letters in the beggining of sentence :)
| $q.notify({ message: result?.error?.message, type: 'negative' }) | ||
| const result = await claimPayment({ campaignCode: advertise.campaignCode, currentAmounSpentInMatic: currentAmountSpent.toString() }) | ||
| if (result.status.includes('success')) { | ||
| $q.notify({ message: 'campaign payment claimed successfully ', type: 'positive' }) |
There was a problem hiding this comment.
Please use capital letters in the beggining of sentence :)
| //let's change the advertise status | ||
| await _completeAdvertise(advertise) | ||
| if (!customWeb3modal.getAddress()) { | ||
| $q.notify({ type: 'negative', message: ' please connect your wallet' }) |
There was a problem hiding this comment.
Please use capital letters in the beggining of sentence :)
| $q.notify({ message: result?.error?.message, type: 'negative' }) | ||
| const result = await requestAndApproveWithdrawal({ campaignCode: advertise.campaignCode, currentAmounSpentInMatic: currentAmounSpent }) | ||
| if (result.status.includes('success')) { | ||
| $q.notify({ message: 'remaing budget withdrawn successfully ', type: 'positive' }) |
There was a problem hiding this comment.
Please use capital letters in the beggining of sentence :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Description
detect wrong network.
correct advertisment flow.
Fixes # (issue)
✨ Type of change
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🧪 All Test Suites Passed?
📸 Screenshots (optional)
Please provide some screenshot for relevant changes
🏎 Quick checklist