This repository has been archived by the owner on Oct 29, 2024. It is now read-only.
Avoid using && in package.json scripts.
#270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Using `&&` locks us into specific shell support requirements which we don't _really_ care about * Using `npm-run-all` will properly use `yarn` or `npm` depending on what is in use in the project.
|
Does this preserve ordering of the logs in general? Just don't want to get the different outputs mixed up |
|
Realized that the jobs in Actions were split up anyways, which is all I really cared about. |
Yes, it does not run them in parallel by default (though there is a way to do that) so the resulting log output is still in the correct order. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
&&locks us into specific shell support requirements which we don't really care aboutnpm-run-allwill properly useyarnornpmdepending on what is in use in the project.