Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip assert and deprecate from the benchmark #1315

Merged
merged 1 commit into from
May 22, 2021

Conversation

pzuraq
Copy link
Member

@pzuraq pzuraq commented May 22, 2021

When we added the assert and deprecate global context APIs, we did
not add removal of them to the benchmark's build process. This PR adds
@rollup/plugin-strip to handle removing them. It appears to work well,
as long as the names are consistent and not overlapping (which they are
currently).

When we added the `assert` and `deprecate` global context APIs, we did
not add removal of them to the benchmark's build process. This PR adds
`@rollup/plugin-strip` to handle removing them. It appears to work well,
as long as the names are consistent and not overlapping (which they are
currently).
@pzuraq pzuraq merged commit e481a91 into master May 22, 2021
@pzuraq pzuraq deleted the strip-assert-deprecate-from-benchmark branch May 22, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant