You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We landed support for default helper manager in #1348. However, we forgot to include a way to turn the feature off. This is needed because every new feature landing in Ember need to be flagged. The general idea is:
In here, we need to add a boolean flag for the feature (either directly on the interface, or nested under features or something). please the export:
We landed support for default helper manager in #1348. However, we forgot to include a way to turn the feature off. This is needed because every new feature landing in Ember need to be flagged. The general idea is:
In here, we need to add a boolean flag for the feature (either directly on the interface, or nested under
features
or something). please the export:glimmer-vm/packages/@glimmer/global-context/index.ts
Line 138 in e00baec
Then in the new code introduced in Implement Default Helper Manager (RFC #756) #1348, we can add a conditional that import and checks that flag prior to returning the default helper manager.
Then we will add an Ember feature flag on the Ember side, and reference it in here: https://github.com/emberjs/ember.js/blob/f89dd90290e993ce8bc9ea5f7f103a82687a2be9/packages/%40ember/-internals/glimmer/lib/environment.ts#L21
Release these as 0.84.1 and tweak Upgrade glimmer emberjs/ember.js#20013 accordingly
cc @wagenet @NullVoxPopuli (though I don't think either one of them has the time to do it, so feel free to pick this up)
The text was updated successfully, but these errors were encountered: