Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature flag for default helper manager #1383

Closed
chancancode opened this issue Mar 8, 2022 · 1 comment · Fixed by #1384
Closed

Feature flag for default helper manager #1383

chancancode opened this issue Mar 8, 2022 · 1 comment · Fixed by #1384

Comments

@chancancode
Copy link
Contributor

chancancode commented Mar 8, 2022

We landed support for default helper manager in #1348. However, we forgot to include a way to turn the feature off. This is needed because every new feature landing in Ember need to be flagged. The general idea is:

  1. In here, we need to add a boolean flag for the feature (either directly on the interface, or nested under features or something). please the export:

    export interface GlobalContext {

  2. Then in the new code introduced in Implement Default Helper Manager (RFC #756) #1348, we can add a conditional that import and checks that flag prior to returning the default helper manager.

  3. Then we will add an Ember feature flag on the Ember side, and reference it in here: https://github.com/emberjs/ember.js/blob/f89dd90290e993ce8bc9ea5f7f103a82687a2be9/packages/%40ember/-internals/glimmer/lib/environment.ts#L21

  4. Release these as 0.84.1 and tweak Upgrade glimmer emberjs/ember.js#20013 accordingly

cc @wagenet @NullVoxPopuli (though I don't think either one of them has the time to do it, so feel free to pick this up)

@locks
Copy link
Contributor

locks commented Mar 10, 2022

@chancancode do you know of a feature flag example in glimmer-vm that a contributor could base themselves on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants