New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unregister on 'stop' #685

Open

jhmartin opened this issue Jun 9, 2020 · 0 comments

jhmartin commented Jun 9, 2020

https://github.com/gliderlabs/registrator/blob/master/registrator.go#L180-L184 indicates Registrator deregisters when a container exits. Clients of the service will have already received an error at that point. It'd be more graceful to mark the instance of the service as in maintenance mode concurrent with the 'stop' phase.

https://www.consul.io/api/agent/service.html#sample-request-4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment