Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change base scope? #24

Open
aaronjensen opened this issue Jul 11, 2018 · 2 comments
Open

Change base scope? #24

aaronjensen opened this issue Jul 11, 2018 · 2 comments

Comments

@aaronjensen
Copy link

Thanks for the great gem, it's been really helpful.

We ran into a situation where we wanted to change the base scope, specifically to add a join (we were ordering on a joined table's field). It doesn't appear that there was a way to do that, so we defined our own scopes that wrapped the scopes generated by order_query. What would you think about a PR to enable overriding the base scope instead of hard-coding all?

Thanks!

@glebm
Copy link
Owner

glebm commented Jul 18, 2018

Sounds good to me!

@davidfetter
Copy link

Bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants