Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8 support, new release, maintenance #793

Closed
czosel opened this issue Oct 23, 2021 · 5 comments
Closed

PHP8 support, new release, maintenance #793

czosel opened this issue Oct 23, 2021 · 5 comments

Comments

@czosel
Copy link
Collaborator

czosel commented Oct 23, 2021

Hi @ichiriac

As you know several PHP8 related features have been merged into the php8 branch of this repository. Until now we've held off of merging back into master because no one felt confident enough without your approval. Now I think it would be time to try to get it merged back into the master branch though, before the two branches diverge too much. Do you think you might find the time to take a look at the changes? Or shall we go ahead and merge it back into master without your review?
After we merged back into master, it would be great to get a new release out (see prettier/plugin-php#1836).

I know all too well how hard it can be to find time for OSS work and also that sometimes priorities can change. If you'd like some help with any aspect of the maintenance process, please let us know - I think the project is popular enough that one or two people could be found. I don't want to pressure you in any way though - if you'd prefer to continue as is, that's totally fine of course.

@ichiriac
Copy link
Member

Hi @czosel

Many thanks to all contributors for all your work. I'll do my best to review and start a release today. We'll can talk after the release how you see maintenance for next releases and what you need.

Thanks again to all of you,
BR,
Ioan

@ichiriac
Copy link
Member

ichiriac commented Oct 24, 2021

My todo list :

  • Update dependencies
  • Pass builds on travis
  • Code Review on PR

@ichiriac
Copy link
Member

Hi @czosel,

If you have some time today, I'm trying to replace travis by circleci, please could you help me with that so I'll focus on code review. I also need to keep track of code coverage, I was made by travis before.

@czosel
Copy link
Collaborator Author

czosel commented Oct 24, 2021

Hi @ichiriac

Thanks for your quick response - sounds great!

I'd be happy to help with getting the CI to work correctly again, and hope to find some time for that tonight. Would you also be open to move to GitHub actions instead of circleCI?

@ichiriac
Copy link
Member

ichiriac commented Oct 24, 2021 via email

@jaulz jaulz mentioned this issue Nov 2, 2021
1 task
@czosel czosel closed this as completed Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants