Fix REPL break on improper errors #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This line has been in here since Coco, and I can't see any reason why it should be kept. Can you?
This is an ugly hack, but it fixes the issue where the REPL will sometimes stop responding to arrow keys after an error has been thrown in user code. Turns out, this happens whenever a string (or anything other than something with Error in its prototype hierarchy) is thrown. The fix is to restore "raw mode" on the input TTY handle when this situation is detected, by the time-honored method of turning it off and on again.
|
what happened to the full repl implementation that was there last night? I was gonna give it a go today... looked pretty extensive edit; oops, nevermind... didn't see the there were two prs... nice! |
|
Almost all of that REPL code is still there; I just pulled it out of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an ugly hack, but it fixes the issue where the REPL will
sometimes stop responding to arrow keys after an error has been thrown
in user code. Turns out, this happens whenever a string (or anything
other than something with Error in its prototype hierarchy) is thrown.
The fix is to restore "raw mode" on the input TTY handle when this
situation is detected, by the time-honored method of turning it off and
on again.
There's also a (basically) one-line commit in here that cleans up a double [Function] message that has been hanging around since Coco.
Close #733