Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step duration time in html report always shows 0s #61

Closed
sampreethnd opened this issue Apr 17, 2017 · 14 comments
Closed

Step duration time in html report always shows 0s #61

sampreethnd opened this issue Apr 17, 2017 · 14 comments

Comments

@sampreethnd
Copy link

I'm using cucumber-html-reporter with nightwatch-cumber. The cucumber_report.json file generated after running the tests has step duration in milliseconds. For calculating the step duration, it looks like cucumber-html-reporter always expects the step duration to be in nanoseconds, due to this the step duration in the html report is always shown as 0s. Could this issue be looked into please?

@stevehipwell
Copy link

We're seeing the same issue here.

cucumber-js: 2.0.0-rc.9

@gkushang
Copy link
Owner

I believe #62 would solve the issue. Could you please verify, or paste the sample JSON for us to verify?

@sampreethnd
Copy link
Author

@gkushang I verified with #62, it does solve the issue. When will this change be released?

@gkushang
Copy link
Owner

@sampreethnd thanks for verifying. The PR is still open. I expect to publish in next two days - will update here!

@sampreethnd
Copy link
Author

@gkushang thanks a lot. That would be great.

@gkushang
Copy link
Owner

the fix is published with v0.4.1

@stevehipwell
Copy link

@gkushang I'm now seeing no duration rather than 0s.

@gkushang
Copy link
Owner

@stevehipwell good catch! Fixed with v0.4.2

@stevehipwell
Copy link

@gkushang it looks like it's back to reporting 0s.

@gkushang
Copy link
Owner

It will report 0 if in nanosecond. Can you share your json sample or a step duration?

@stevehipwell
Copy link

@gkushang I've attached a sample report with two scenarios.

cucumber.zip

@gkushang
Copy link
Owner

gkushang commented May 2, 2017

thanks @stevehipwell. There are lot of changes in Cucumber V2 after digging through the change log, e.g. the duration is changed to milliseconds from nano and also the attachment API changed as well. To support Cucumber V2, we will be releasing the major version and will keep the current version as a backward compatible. Re-opening the issue as it's not completely resolved yet.

@gkushang
Copy link
Owner

gkushang commented Jun 9, 2017

#81 will fix this issue

@gkushang
Copy link
Owner

gkushang commented Jun 9, 2017

published the fix with [email protected]. Please try it out, and let us know how it works.

@gkushang gkushang closed this as completed Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants