Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop inlining screenshots? #145

Closed
joeboon opened this issue Jun 12, 2018 · 2 comments
Closed

Stop inlining screenshots? #145

joeboon opened this issue Jun 12, 2018 · 2 comments

Comments

@joeboon
Copy link

joeboon commented Jun 12, 2018

When configured to store screenshot files using "storeScreenshots: true," I was expecting it to stop storing them inline in the HTML. So the screenshots are stored in files, but not referenced by the HTML, and are duplicates inline in the HTML. This is using twice the disk space. Have I misunderstood this setting?

If correct, are there any objections to adding a new option "inlineScreenshots" which defaults to true? When false, the HTML report would include the image using an img tag, and link to the image file.

@gkushang
Copy link
Owner

@joeboon

storeScreenshots is a flag which store screenshots locally on the disk if storeScreenshots:true otherwise it would only include on HTML report. In anycase, either true or false, the screenshots would be on HTML as inline. This flag does not control the Inline Screenshots.

Please create the feature request if you are looking for any specific feature.

@joeboon
Copy link
Author

joeboon commented Jun 29, 2018

Thank you for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants