Supporting HTML tag in screenshot embeddings?

[xywang68]

In order to avoid a huge cucumber-result.json file, instead of embedding the screenshot image as base64 data, I want to attach a HTML tag string like <img>. I am able to attach the tag using scenario.attach() call, but the cucumber-html-reporter is not showing.
Am I not doing this correctly? Otherwise can this be supported?

Here is my code in hooks.js:
var html_tag = '<img src="pulpitrock.jpg" alt="Mountain View">'; scenario.attach(Buffer.from(html_tag, 'utf-8'), 'text/html');

Here is the cucumber result JSON after run:
"embeddings": [ { "data": "PGltZyBzcmM9InB1bHBpdHJvY2suanBnIiBhbHQ9Ik1vdW50YWluIFZpZXciPg==", "mime_type": "text/html" } ],
which the data can be base64 decoded back to the original html_tag string.

[xywang68]

Hi, I subsequently made a small update in the lib/reporter.js with the following code in bold and it seems to work as I have requested above:

if (embeddingType === 'text/plain' || embeddingType === 'text/html') {
var decoded = new Buffer(embedding.data, 'base64').toString('ascii');

if (!step.text) {
step.text = decoded;
} else {
step.text = step.text.concat('
' + embedding.data);
}
} else if (embeddingType === 'application/json') {

[xywang68]

Here is the git diff. If this looks OK to you I can submit a PR.

$ git diff lib/reporter.js
warning: LF will be replaced by CRLF in lib/reporter.js.
The file will have its original line endings in your working directory.
diff --git a/lib/reporter.js b/lib/reporter.js
index a4b7320..1318918 100755
--- a/lib/reporter.js
+++ b/lib/reporter.js
@@ -220,9 +220,11 @@ var generateReport = function (options) {
embeddingType = embedding.media.type;
}

- if (embeddingType === 'text/plain') {
+ if (embeddingType === 'text/plain' || embeddingType === 'text/html') {
+ var decoded = new Buffer(embedding.data, 'base64').toString('ascii');
+
if (!step.text) {
- step.text = embedding.data;
+ step.text = decoded;
} else {
step.text = step.text.concat('
' + embedding.data);
}

[gkushang]

@xywang68 thanks for looking into it. Please submit a PR

[xywang68]

@gkushang , I tried to submit a branch to your git but got access denied. Can you grant permission for me to submit a branch? Or is there another way you prefer me to do?

[gkushang]

Hi @xywang68 - You'd not need to push the branch to the Origin. Please fork a repository, and submit a PR from your forked.

[xywang68]

@gkushang, created PR#132.

[gkushang]

Thanks for the PR. All set!