Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to clear a file annotation on a split file w/o the annotation no-ops #3914

Closed
eamodio opened this issue Jan 8, 2025 · 1 comment
Assignees
Labels
bug Something isn't working needs-verification Request for verification pending-release Resolved but not yet released to the stable edition
Milestone

Comments

@eamodio
Copy link
Member

eamodio commented Jan 8, 2025

Steps to repro:

  • Split an editor into 2 tabs so they are side-by-side
  • Switch to the left file
  • Toggle a file annotation (blame, heatmap, changes, doesn't matter which) in the left file
  • Switch to the right file
  • 🐛 Attempt to clear the file annotation and nothing will happen
@eamodio eamodio added the bug Something isn't working label Jan 8, 2025
@eamodio eamodio added this to the 16.2 milestone Jan 8, 2025
@eamodio eamodio self-assigned this Jan 8, 2025
@eamodio eamodio closed this as completed in 53e7cc0 Jan 8, 2025
@eamodio
Copy link
Member Author

eamodio commented Jan 8, 2025

Since, we can't effectively manage the editor toolbar states (vscode limitation), we will just link the "clear" to clear annotations across all splits of the same editor.

We could also choose to link the editors when turning on the annotations, but I haven't done that because it feels like too much.

@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for verification labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-verification Request for verification pending-release Resolved but not yet released to the stable edition
Projects
None yet
Development

No branches or pull requests

1 participant