Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to yauzl for variant analysis results #3151

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Switch to yauzl for variant analysis results #3151

merged 2 commits into from
Dec 19, 2023

Conversation

koesie10
Copy link
Member

This switches the variant analysis results to yauzl instead of unzipper. There should be no changes in behavior.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 force-pushed the koesie10/variant-analysis-yauzl branch from eb8191b to 2efca58 Compare December 18, 2023 14:03
@koesie10 koesie10 force-pushed the koesie10/variant-analysis-yauzl branch from 2efca58 to 7708347 Compare December 18, 2023 14:10
@koesie10 koesie10 marked this pull request as ready for review December 18, 2023 14:25
@koesie10 koesie10 requested review from a team as code owners December 18, 2023 14:25
charisk
charisk approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not loving how "manual" unzipping is but it is what it is!

@koesie10 koesie10 merged commit e89a04d into main Dec 19, 2023
14 checks passed
@koesie10 koesie10 deleted the koesie10/variant-analysis-yauzl branch December 19, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charisk charisk charisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koesie10 @charisk