Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-Origin Resource Sharing (CORS) #331

Closed
somethingnew2-0 opened this issue May 26, 2017 · 4 comments
Closed

Cross-Origin Resource Sharing (CORS) #331

somethingnew2-0 opened this issue May 26, 2017 · 4 comments
Labels

Comments

@somethingnew2-0
Copy link

This is more of a question than a feature request, is there a historical reason the Cross-Origin Resource Sharing (CORS) headers aren't included in the list of headers configured by secureheaders? Has it just not been implemented yet? Do you all recommend using rack-cors as a complement to secureheaders instead of including this feature directly? Just curious 😄

@oreoshake
Copy link
Contributor

Has it just not been implemented yet?

It hasn't even been discussed from what I can tell or remember.

History 💤

is there a historical reason the Cross-Origin Resource Sharing (CORS) headers aren't included in the list of headers configured by secureheaders?

My guess would be that CORS is flat out required for a lot of things on the internet today. Building on top of that, more people have experience configuring CORS and more providers have configuration APIs/configs/etc.

e.g. AWS has supported CORS for years and provides a way to set values, but makes it a pain to enable hsts(and apparently has only recently started supporting it).

This library set out as a way to apply headers that were optional and often overlooked.

📖 💤 😴

Present ⌚️

I haven't used rack-cors but maybe @ejcx has or has an opinion?

Future 🚀

I could see this living in secure_headers.

@ejcx
Copy link

ejcx commented May 26, 2017

Hey @oreoshake thanks for the ping. rack-cors actually has a fundamental problem that I wrote about almost a year ago: cyu/rack-cors#126

One thing to look out for is libraries that reflect an origin header when you specify an Access-Control-Allow-Origin policy of *. * should be *.

@oreoshake
Copy link
Contributor

I'm going to take the possibly unpopular opinion and saying that CORS is too application specific to be handled by this library given the alternatives.

I welcome all opinions counter to this proposal but stale issue should be closed.

@ejcx
Copy link

ejcx commented May 6, 2021

That's fair @oreoshake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants