-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Imba programming language #3869
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes required, however they may be moot given my next note.
type: grammar | ||
name: language-imba | ||
license: mit | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks to have been manually added rather than pulled in from the grammar repo itself.
The grammar repo needs to explicitly include a license file which script/add-grammar
will automatically pull in and assess.
@@ -0,0 +1 @@ | |||
console.log "Hello, World!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this sample. We require only real-world usage samples and "hello world" is never real-world usage 😉
Sorry about the delay in getting to this PR. Unfortunately, it isn't popular enough on GitHub for this PR to be merged. At the moment, the stats are: Total files found: 444 As per the contributing guidelines at https://github.com/github/linguist/blob/master/CONTRIBUTING.md#adding-an-extension-to-a-language "we prefer that extensions be in use in hundreds of repositories before supporting them in Linguist." Accordingly, I'll added the "Pending popularity" label. |
Hei, what is the status on this? #4219 says there 58 repositories but this query shows more than 300 Thanks. |
@pchaigno ah, thanks for clarifying. |
Hello. is this language popular nowadays? |
There's 1K results now, minus the |
Read about imba at imba.io. It has 1.9k stars on GitHub. usage