Make PostScript red again #3141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, here's the before-and-after for Scala's colour adjustment: Here's Red's adjustment, although it's harder to notice. I made an animated GIF to show the change: |
26 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second crack at what I tried doing a couple months ago. This PR sets the colour of PostScript to PANTONE 485 C, as per the language's branding. And if there's ANY language whose colours deserve to retain their tonal integrity, it's the language that pretty much pioneered the whole world of desktop publishing.
The conflicting colours (Scala and, uhm, "Red") were pushed apart somewhat. Red was made redder, and Scala was given a desaturated darker shade of red. Scala's change is a bit more noticeable than Red's, but it was too close to HTML's colour anyway.
I'd show you a "before-and-after", but my Internet connection decided to die as I was looking for a repository that'd show a Red/HTML comparison. I've had to copy+paste this PR message to my phone to post it using my data. Whoever said Australia is the "lucky country" clearly wasn't talking about our fucking Internet.