Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue.js language color #4448

Closed
4 tasks done
shrpne opened this issue Mar 6, 2019 · 5 comments
Closed
4 tasks done

Vue.js language color #4448

shrpne opened this issue Mar 6, 2019 · 5 comments

Comments

@shrpne
Copy link

shrpne commented Mar 6, 2019

Preliminary Steps

Please confirm you have...

Problem Description

I think Vue language color should be changed.
Now it is gray with blue tone: #2c3e50.
But primary color on the https://vuejs.org/ website and Vue logo is green: #42b983

@lildude
Copy link
Member

lildude commented Mar 6, 2019

But primary color on the https://vuejs.org/ website and Vue logo is green: #42b983

Not quite... the text logo in the top left is actually #2c3e50:

vue js 2019-03-06 11-12-52

... and from the original PR that added support for Vue - #2513 (comment) - that colour was chosen as #42b983 is too close to another already in use by Linguist.

We're currently waiting on GitHub's design team to see if we can remove this proximity check so languages can have their brand colours, but until such time as that has been approved, such a change is not going to be possible.

Additionally, if we were to change the colour, we will require some sort of brand guidelines and community consensus (the Vue community in this case) on the change before we do so, especially for languages like Vue that have had the same colour for many years. Many people have grown to love the colours currently used and get quite upset when these change without rhyme or reason or community consensus.

@shrpne
Copy link
Author

shrpne commented Mar 6, 2019

Well, as I can see, it's the color of titles and leadings.
image
This color looks like base text color for me and I can't associate it with Vue.
I hope this color conflict with other languages will be resolved somehow. Thank you!

@stale
Copy link

stale bot commented Apr 5, 2019

This issue has been automatically marked as stale because it has not had activity in a long time. If this issue is still relevant and should remain open, please reply with a short explanation (e.g. "I have checked the code and this issue is still relevant because ___."). Thank you for your contributions.

@stale stale bot added the Stale label Apr 5, 2019
@shrpne
Copy link
Author

shrpne commented Apr 5, 2019

We're currently waiting on GitHub's design team to see if we can remove this proximity check so languages can have their brand colours

So I think we are still waiting

@stale stale bot removed the Stale label Apr 5, 2019
@lildude
Copy link
Member

lildude commented Apr 5, 2019

That's not gonna change any time soon. We're more waiting on:

Additionally, if we were to change the colour, we will require some sort of brand guidelines and community consensus (the Vue community in this case) on the change before we do so, especially for languages like Vue that have had the same colour for many years. Many people have grown to love the colours currently used and get quite upset when these change without rhyme or reason or community consensus.

There has been no indication that the community has been consulted about this change.

If this has been discussed and approved, we'd like to a link to that discussion showing the consensus.

This issue is not the place to gain that consensus.

@shrpne shrpne closed this as completed Apr 5, 2019
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants