Skip to content

Commit

Permalink
Detect go files as generated according to official rules (#4821)
Browse files Browse the repository at this point in the history
  • Loading branch information
ernestas2k authored Mar 17, 2020
1 parent 96ca71a commit f5125ea
Show file tree
Hide file tree
Showing 4 changed files with 54 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/linguist/generated.rb
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ def generated_go?
return false unless extname == '.go'
return false unless lines.count > 1

return lines[0].include?("Code generated by")
return lines.first(10).any? { |l| l.include? "Code generated by" }
end

PROTOBUF_EXTENSIONS = ['.py', '.java', '.h', '.cc', '.cpp', '.m', '.rb']
Expand Down Expand Up @@ -605,7 +605,7 @@ def generated_gamemakerstudio?
return lines[2].match(/\"modelName\"\:\s*\"GM/) ||
lines[0] =~ /^\d\.\d\.\d.+\|\{/
end

# Internal: Is this a generated GIMP C image file?
#
# GIMP saves C sources with one of two comment forms:
Expand Down
50 changes: 50 additions & 0 deletions samples/Go/oapi-codegen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions test/test_blob.rb
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ def test_generated
assert sample_blob_memory("Python/protocol_buffer_pb2.py").generated?
assert sample_blob_memory("Go/api.pb.go").generated?
assert sample_blob_memory("Go/embedded.go").generated?
assert sample_blob_memory("Go/oapi-codegen.go").generated?
assert sample_blob_memory("JavaScript/proto.js").generated?

# Apache Thrift generated code
Expand Down
1 change: 1 addition & 0 deletions test/test_file_blob.rb
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@ def test_generated
assert sample_blob("Python/protocol_buffer_pb2.py").generated?
assert sample_blob("Go/api.pb.go").generated?
assert sample_blob("Go/embedded.go").generated?
assert sample_blob("Go/oapi-codegen.go").generated?

# Apache Thrift generated code
assert sample_blob("Python/gen-py-linguist-thrift.py").generated?
Expand Down

0 comments on commit f5125ea

Please sign in to comment.