Remove support for old versions of npm and go #602
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will remove all support for older versions of npm and go, where the older versions are now end-of-life'd. Generally, licensed tries to maintain support for actively supported versions of tools to keep the code in the repo easier to maintain. With the upcoming major version bump in licensed to v4.0.0, it is a good time to cleanup some logic specific to older versions of tools which could be a breaking change to some users.
Go supports the most recent two minor release versions, which are 1.18 and 1.19. Licensed supports one additional version beyond that, 1.17. The go source had some logic related to using the
go
CLI at versions< 1.11.0
which has been removed.Node's oldest LTS major version is 14, where node 14.0.0 corresponds to npm version 7.10. The npm source included a version check where the CLI args need to be different for versions>= 7.0.0
. I've made that behavior the default now with the removal of node 12 support. In this case I've also updated the tested versions of the npm source, removing 12 and adding 18.EDIT: I don't know what I was looking at, node 14.0.0 corresponds to node 6.14.4. I've reverted the changes to the npm source and tests, and only updated the tested versions in CI