Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for old versions of npm and go #602

Merged
merged 4 commits into from
Jan 2, 2023
Merged

Conversation

jonabc
Copy link
Contributor

@jonabc jonabc commented Jan 2, 2023

This PR will remove all support for older versions of npm and go, where the older versions are now end-of-life'd. Generally, licensed tries to maintain support for actively supported versions of tools to keep the code in the repo easier to maintain. With the upcoming major version bump in licensed to v4.0.0, it is a good time to cleanup some logic specific to older versions of tools which could be a breaking change to some users.

Go supports the most recent two minor release versions, which are 1.18 and 1.19. Licensed supports one additional version beyond that, 1.17. The go source had some logic related to using the go CLI at versions < 1.11.0 which has been removed.

Node's oldest LTS major version is 14, where node 14.0.0 corresponds to npm version 7.10. The npm source included a version check where the CLI args need to be different for versions >= 7.0.0. I've made that behavior the default now with the removal of node 12 support. In this case I've also updated the tested versions of the npm source, removing 12 and adding 18.

EDIT: I don't know what I was looking at, node 14.0.0 corresponds to node 6.14.4. I've reverted the changes to the npm source and tests, and only updated the tested versions in CI

@jonabc
Copy link
Contributor Author

jonabc commented Jan 2, 2023

well that's odd. After the CI failure I took another look at the npm version that ships with each version of node and it looks like the bump to 7.10 happens with node 16, where node 14 still uses the 6.x npm major version 🤦 . I'm not sure how I missed that the first time around. Anyway, I've reverted that commit and only updated the versions tested in CI to remove node 12 and add node 18

@jonabc jonabc merged commit e94eeb9 into master Jan 2, 2023
@jonabc jonabc deleted the trim-old-versions branch January 2, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant