Order dependency records contents before comparing #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as long as the license text and sources are the same, it doesn't matter what order they're found
|
The Please review the pull request for any additional changes required and merge when ready. |
…n-licenses License updates for ordered-license-content-comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When licensed and/or licensee is looking for license files in a repo it doesn't look like there is any explicit content ordering, which makes it possible for a version upgrade of a dependency to find licenses in a different order than what's present in a cached file.
This PR adds a sort key for
DependencyRecord::Licenseobjects. The key is used inDependencyRecord#contentto make the comparison between license contents read from a stored metadata file in the repo and license contents found from live dependency listing order-agnostic.