Don't crash yarn source on malformed json #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Please review the pull request for any additional changes required and merge when ready. |
License updates for yarn-handle-malformed-json
jonabc
added a commit
that referenced
this pull request
Jan 7, 2022
## 3.4.1 2022-01-07 ### Fixed - Malformed package.json files will no longer crash yarn dependency detection (#431)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #430
This is a minimal fix to resolve the crash. In the linked issue the problem came from a dependency shipping it's intentionally malformed test fixture, which is not required and fine to ignore. If there is an error when parsing a required package.json file with this change, a dependency will show up as not being found rather than the true error that package.json file couldn't be parsed. That can be handled at a later time though
cc @pfeffer