Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Swift / Swift Package Manager #363

Merged
merged 14 commits into from
May 27, 2021
Merged

Conversation

mattt
Copy link
Contributor

@mattt mattt commented May 19, 2021

This PR adds support for Swift Package Manager to Licensed.

This will need to be updated once the Swift package registry is implemented. But for now, it works with existing URL-based dependency declarations.

Copy link
Contributor

@jonabc jonabc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! thank you for starting this PR 🙇 , I left a few comments based on things I wasn't able to find quickly online. if any of my questions are easily readable please don't hesitate to share a link, it's often easier to ask where to look for information rather than trudging through search results 😄

lib/licensed/sources/swift.rb Outdated Show resolved Hide resolved
lib/licensed/sources/swift.rb Outdated Show resolved Hide resolved
lib/licensed/sources/swift.rb Outdated Show resolved Hide resolved
lib/licensed/sources/swift.rb Outdated Show resolved Hide resolved
lib/licensed/sources/swift.rb Outdated Show resolved Hide resolved
@mattt mattt marked this pull request as ready for review May 21, 2021 19:11
@mattt mattt requested a review from jonabc May 25, 2021 18:04
Copy link
Contributor

@jonabc jonabc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, left two small comments. 👍 to merge once those are resolved

lib/licensed/sources/swift.rb Outdated Show resolved Hide resolved
lib/licensed/sources/swift.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@jonabc jonabc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ thanks for putting this all together 👍

@jonabc jonabc merged commit c06e0da into licensee:master May 27, 2021
@mattt
Copy link
Contributor Author

mattt commented May 27, 2021

@jonabc Thanks so much for your help to make this happen!

jonabc added a commit that referenced this pull request Jun 16, 2021
## 3.1.0

2021-06-16

### Added

- Licensed supports Swift/Swift package manager as a dependency source (:tada: @mattt #363)'

### Changed

- The `source_path` configuration property accepts arrays of inclusion and exclusion glob patterns (#368)
- The Nuget source now uses configured fallback folders to find dependencies that are not in found in the project folder (#366)
- The Nuget source supports a configurable property for the path from the project source path to the project's `obj` folder (#365)

### Fixed
- The Go source's checks for local packages will correctly find paths in case-insensitive file systems (#370)
- The Bundler source will no longer unnecessarily reset the local Bundler environment configuration (#372)
@jonabc jonabc mentioned this pull request Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants