Ignore extraneous, missing npm dependencies #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonabc
added a commit
that referenced
this pull request
Mar 29, 2021
## 2.15.0 2021-03-24 ### Changed - The npm source will ignore dependencies that are marked as both extraneous and missing (#347)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw this in a project where two versions of react would have been installed based on direct and indirect dependency requirements. npm decided to only install one while labelling the other as both "extraneous" and "missing". I'm not sure if there is more to this story but I think generally this is a case that would make sense to ignore as not installed in a project.
I tried to find a package that I could use to test this but had a hard time of it, but for some minimal verification I was able to build and run this change locally to verify it fixed the issue I was seeing in my project.