Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'applier' and 'inspector' commands to server #951

Merged
merged 8 commits into from
Apr 4, 2021

Conversation

timvaillancourt
Copy link
Collaborator

@timvaillancourt timvaillancourt commented Apr 2, 2021

Description

This PR introduces two new commands for the unix-socket/TCP server:

  1. applier - list the MySQL hostname of the applier
  2. inspector - list the MySQL hostname of the inspector

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

cc @gtowey / @TeeKraken / @shlomi-noach

@timvaillancourt timvaillancourt changed the title Add server cmd hosts Add 'applier' and 'inspector' commands to server Apr 2, 2021
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timvaillancourt timvaillancourt added this to the v1.1.1 milestone Apr 3, 2021
@timvaillancourt
Copy link
Collaborator Author

Example output w/applier+inspector on same host:

tim@Tims-MacBook-Pro /tmp % echo applier | nc -U /tmp/gh-ost.test.test.sock
Host: 4031462df3a9:3306, Version: 5.7.33-log
tim@Tims-MacBook-Pro /tmp % echo inspector | nc -U /tmp/gh-ost.test.test.sock
Host: 4031462df3a9:3306, Version: 5.7.33-log

That's the final tweak before merging

@timvaillancourt timvaillancourt merged commit d95dda3 into github:master Apr 4, 2021
@timvaillancourt timvaillancourt deleted the add-server-cmd-hosts branch April 4, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants