Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributing: Fix links #249

Merged
merged 5 commits into from
Oct 9, 2020
Merged

Contributing: Fix links #249

merged 5 commits into from
Oct 9, 2020

Conversation

Simran-B
Copy link
Contributor

@Simran-B Simran-B commented Oct 8, 2020 •
edited
Loading

Why:

Some of the links in CONTRIBUTING.md are broken.

What's being changed:

Fix two typos and change anchor link to forking section, which does not have dedicated headlines for GitHub Desktop and command-line.

There are a couple more dead anchor links, but it looks like the content does not exist yet?

- [Resolving merge conflicts](#resolving-merge-conflicts)
  - [In the GitHub user interface](#in-the-github-user-interface)
    - [Editing the file and committing the changes](#editing-the-file-and-committing-the-changes)
- [Troubleshooting](#troubleshooting)
  - [Failed status checks](#failed-status-checks)
- [Draft pull requests](#draft-pull-requests)

Check off the following:

@welcome
Copy link

welcome bot commented Oct 8, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

janiceilene
janiceilene requested changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching these @Simran-B! I added one suggestion. Once you accept that suggestion, we can review it again and get this merged in ⚡

@janiceilene janiceilene added the contributing docs Content related to our contributing docs label Oct 8, 2020
@Simran-B Simran-B requested a review from janiceilene October 8, 2020 20:43
@Simran-B
Copy link
Contributor Author

Simran-B commented Oct 8, 2020

You're welcome @janiceilene. Applied your suggestion. Can be merged, but you may want to address the remaining dead anchor links in another PR one way or the other.

@janiceilene
Copy link
Contributor

@Simran-B Thanks for pointing those out! We did some last minute restructuring of this doc and must have missed the table of contents 😅 Would you open an issue about the broken links you found? Maybe someone else will get to fixing them before I do 🤞

I'll merge this in as soon as the branch is updated and all of the tests are green 💚

@janiceilene janiceilene merged commit 546978e into github:main Oct 9, 2020
@janiceilene
Copy link
Contributor

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

@Simran-B Simran-B deleted the patch-1 branch October 9, 2020 14:39
@Simran-B Simran-B mentioned this pull request Oct 9, 2020
Closed
@Simran-B
Copy link
Contributor Author

Simran-B commented Oct 9, 2020

@all-contributors please add Simran-B for doc

@allcontributors allcontributors bot mentioned this pull request Oct 9, 2020
Closed
@allcontributors
Copy link
Contributor

@Simran-B

I've put up a pull request to add @Simran! 🎉

@Simran-B
Copy link
Contributor Author

Simran-B commented Oct 9, 2020

Sorry, wrong user 😞

@all-contributors please add @Simran-B for doc

@allcontributors allcontributors bot mentioned this pull request Oct 9, 2020
Merged
@allcontributors
Copy link
Contributor

@Simran-B

I've put up a pull request to add @Simran-B! 🎉

@Anmar1988260 Anmar1988260 mentioned this pull request Feb 9, 2021
Open
@montana910318 montana910318 mentioned this pull request Feb 9, 2021
Open
@YoYBaBy YoYBaBy mentioned this pull request Mar 2, 2021
Open
This was referenced Mar 9, 2021
Open
Open
@Dmarch28 Dmarch28 mentioned this pull request Mar 11, 2021
Open
@YoYBaBy YoYBaBy mentioned this pull request Mar 14, 2021
Open
This was referenced Mar 16, 2021
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 24, 2021
Open
This was referenced Apr 2, 2021
Open
Open
This was referenced Apr 9, 2021
Open
Open
This was referenced Apr 20, 2021
Open
Open
Open
This was referenced Apr 27, 2021
Open
Open
@snyk-bot snyk-bot mentioned this pull request May 11, 2021
Open
@snyk-bot snyk-bot mentioned this pull request May 27, 2021
Open
This was referenced Jun 6, 2021
Open
Open
Open
This was referenced Jun 14, 2021
Open
Open
@snyk-bot snyk-bot mentioned this pull request Jun 24, 2021
Open
This was referenced Jul 5, 2021
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Dec 16, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Dec 29, 2021
Open
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
@Loquacity @mirandaauhl @jacobprall
404s (github#249)
385b6f0 
* remove leading slashes in links

* Use full URL

* Remove leading slash

* remove unused links from FAQs

* Fix URL to advanced analytic queries

* remove variable from full URL

* Remove leading slash

* Remove unused links

* Remove leading slashes

* Remove trailing slash

* Fix path

* Fix URL

* Update external link

* Update external URL

* fix path

* fix path

* Remove trailing slash

* remove trailing slash

* remove trailing slash

* Remove trailing slashes

* Apply suggestions from code review

Co-authored-by: mirandaauhl <[email protected]>

* Apply suggestions from code review

Co-authored-by: Ryan Booz <[email protected]>

* Apply suggestions from code review

Co-authored-by: mirandaauhl <[email protected]>
Co-authored-by: Ryan Booz <[email protected]>
Co-authored-by: Jacob Prall <[email protected]>
@snyk-bot snyk-bot mentioned this pull request Mar 23, 2023
Open
cmahnke added a commit to cmahnke/docs that referenced this pull request Jul 6, 2024
@cmahnke
Update publishing-nodejs-packages.md
63df6c7 
The provided example doesn't work as acknowledged by the `setup-node` team, as of [github#926](actions/setup-node#926 (comment)). This is also a long known problem, see [github#249](actions/setup-node#249). 

This is considered to be a drastic measure to make sure the `setup-node` team takes responsibility for the problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janiceilene janiceilene janiceilene approved these changes

Assignees
No one assigned
Labels
contributing docs Content related to our contributing docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Simran-B @janiceilene