Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auto-launching ssh-agent for Windows #31497

Closed
1 task done
profojak opened this issue Feb 7, 2024 · 3 comments
Closed
1 task done

Update auto-launching ssh-agent for Windows #31497

profojak opened this issue Feb 7, 2024 · 3 comments
Labels
content This issue or pull request belongs to the Docs Content team fixing internally This will be fixed internally ssh Content related to SSH

Comments

@profojak
Copy link
Contributor

profojak commented Feb 7, 2024

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/authentication/connecting-to-github-with-ssh/working-with-ssh-key-passphrases

What part(s) of the article would you like to see updated?

The Auto-launching ssh-agent on Git for Windows section of the article provides a bash script to automatically run ssh-agent when opening bash or Git shell, but these instructions do not work for Windows-native PowerShell.

Microsoft's documentation has 2 relevant articles that could be linked or quoted in the GitHub's documentation article.

Get started with OpenSSH for Windows article provides instructions on how to install both OpenSSH Client (providing ssh-agent command) and OpenSSH Server (providing ssh-keygen command) using a GUI and how to automatically start the OpenSSH Server service. Key-based authentication in OpenSSH for Windows article provides instructions on how to launch both Client and Server services from the PowerShell:

# Set the sshd service to be started automatically
Get-Service -Name sshd | Set-Service -StartupType Automatic

# Now start the sshd service
Start-Service sshd

ssh-keygen -t ed25519
# By default the ssh-agent service is disabled. Configure it to start automatically.
# Make sure you're running as an Administrator.
Get-Service ssh-agent | Set-Service -StartupType Automatic

# Start the service
Start-Service ssh-agent

# This should return a status of Running
Get-Service ssh-agent

# Now load your key files into ssh-agent
ssh-add $env:USERPROFILE\.ssh\id_ed25519

I believe this information should be included in the GitHub's documentation article.

Additional information

No response

@profojak profojak added the content This issue or pull request belongs to the Docs Content team label Feb 7, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 7, 2024
@GONNAGITU72

This comment was marked as spam.

@nguyenalex836 nguyenalex836 added waiting for review Issue/PR is waiting for a writer's review ssh Content related to SSH and removed triage Do not begin working on this issue until triaged by the team labels Feb 7, 2024
@nguyenalex836
Copy link
Contributor

@profojak Thank you for raising this issue! I'll get this triaged for review ✨ Our team will provide feedback regarding the best next steps for this issue - thanks for your patience! 💛

@guntrip
Copy link
Contributor

guntrip commented Feb 9, 2024

Hi @profojak, thanks for opening this! There's so many ways to configure Git and SSH on Windows, our docs favour Git for Windows and step into Powershell when necessary to configure something. I think we risk making things confusing by adding too many different options but, on this particular page, I don't think that's the case and a new section for Powershell users would be beneficial.

We're currently working on a lot of changes to the SSH docs, so I'm going to transfer this issue internally so that the team can work on it.

Thank you so much for suggesting this, I think this will help a lot of folks! ✨

@guntrip guntrip added fixing internally This will be fixed internally and removed waiting for review Issue/PR is waiting for a writer's review labels Feb 9, 2024
@guntrip guntrip closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team fixing internally This will be fixed internally ssh Content related to SSH
Projects
None yet
Development

No branches or pull requests

4 participants