-
Notifications
You must be signed in to change notification settings - Fork 61k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
developer route redirects load incorrectly on Windows #311
Labels
bug
An error or flaw that causes unintended or unexpected results
engineering
Will involve Docs Engineering
Comments
4 tasks
This was referenced Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
An error or flaw that causes unintended or unexpected results
engineering
Will involve Docs Engineering
What is the current behavior?
On windows many of the content pages show up as having broken links in
tests/links-and-images/links-and-images.js
. for example,What changes are you suggesting?
Turns out that the problem is actually in the parsing of redirects from the loaded pages.
path.join
is used at the end of the function to compute a key. since \ is used instead of /, the key is incorrect and the redirect does not get registered.cc: @github/docs-engineering
The text was updated successfully, but these errors were encountered: