Fix failed SARIF upload behavior when the workflow doesn't call the CodeQL Action #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This created unexpected behavior with a workflow calling `codeql-action/analyze` locally. Therefore, be more conservative with parsing inputs from workflows and refuse to parse jobs that don't call the specified Action exactly once.
This isn't severe enough to appear on the Actions summary.
aeisenberg
approved these changes
Dec 6, 2022
This was referenced Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered some unexpected behavior with a workflow that called
codeql-action/analyzelocally. The workflow parsing code couldn't resolve the local call to the CodeQL Action, and erroneously returned the default values of each input. This meant that we uploaded a failed SARIF file when we shouldn't have.This PR adds a regression test for this case, and changes the workflow parsing code to be more conservative. Now we only upload a failed SARIF file when the current job calls the relevant Action exactly once in the workflow file.
No changelog needed since this functionality hasn't been rolled out yet.
Merge / deployment checklist