Merge pull request #1259 from mschoettle/fix-tooltips

Fix tooltips not showing up on license page and add rule label to tooltips
github · Nov 26, 2024 · 6691649 · 6691649
2 parents 7d8062b + 8106a1a
commit 6691649
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/assets/js/app.coffee b/assets/js/app.coffee
@@ -40,10 +40,10 @@ class Choosealicense
     # Dynamically add annotations as title attribute to rule list items
     for ruletype, rules of window.annotations
       for rule in rules
-        # Only select license elements in table, not legend
-        licenseLiElement = $("td.license-#{ruletype} .#{rule["tag"]}")
+        # Exclude license elements in the legend
+        licenseLiElement = $(".license-#{ruletype} .#{rule["tag"]}").not("dd.license-#{ruletype} .#{rule["tag"]}")
         tooltipAttr = @tooltipAttributesMapperByRuleType[ruletype]
-        licenseLiElement.attr "aria-label", "#{tooltipAttr.heading}: #{rule.description}"
+        licenseLiElement.attr "aria-label", "#{rule.label} #{tooltipAttr.heading.toLowerCase()}: #{rule.description}"
         licenseLiElement.addClass("hint--bottom
                                    hint--large
                                    hint--no-animate