Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing and renamed packages for ubuntu in CONTRIBUTING.md #5245

Closed
wader opened this issue Mar 2, 2021 · 4 comments · Fixed by #5246
Closed

Missing and renamed packages for ubuntu in CONTRIBUTING.md #5245

wader opened this issue Mar 2, 2021 · 4 comments · Fixed by #5246
Labels

Comments

@wader
Copy link
Contributor

wader commented Mar 2, 2021

Describe the bug

Hi while workingon #5233 I was following the steps in CONTRIBUTING.md but there were some missing and renamed packages. Here are the steps I eventually used:

docker run -ti --rm -v "$PWD:$PWD" -w "$PWD" -v /var/run/docker.sock:/var/run/docker.sock ubuntu
apt-get install cmake pkg-config libicu-dev docker.io ruby ruby-dev libz-dev build-essential libssl-dev
gem install bundler
script/bootstrap
script/add-grammar https://github.com/wader/linguist-language-jq
script/update-ids
bundle exec rake samples
bundle exec rake test
@wader wader added the Bug label Mar 2, 2021
@lildude
Copy link
Member

lildude commented Mar 3, 2021

@wader Do you mind opening a PR to update the docs? Things like this can and do happen so PRs are best to keep things up-to-date quickly. 🙇

wader added a commit to wader/linguist that referenced this issue Mar 3, 2021
@wader
Copy link
Contributor Author

wader commented Mar 3, 2021

I guess the list of packages we the only thing really if we don't indent of adding instructions for using docker?

lildude added a commit that referenced this issue Mar 8, 2021
* Update list packages needed for ubuntu

Closes #5245

* Use new libz package name

Co-authored-by: Colin Seymour <[email protected]>

Co-authored-by: Colin Seymour <[email protected]>
@lildude
Copy link
Member

lildude commented Mar 9, 2021

if we don't indent of adding instructions for using docker?

I hadn't considered documenting using Docker for dev until you mentioned it. I'll add it to my TODO list.

@wader
Copy link
Contributor Author

wader commented Mar 9, 2021

Mm i can be quite convenient if you don't want to mess with your host environment too much

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants