Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language bar links exclude files within language groups from search queries #4593

Closed
4 tasks done
supernintendo opened this issue Jul 28, 2019 · 3 comments
Closed
4 tasks done

Comments

@supernintendo
Copy link

Preliminary Steps

Please confirm you have...

Problem Description

Files with parent languages (files with prefixed file extensions that are consolidated into language groups) are excluded from the search results pages that Linguist links to in the language bar. For example, this repository reports "3.7% HTML" usage but when clicking the link in the language bar to view those files, GitHub says it couldn’t find any code. To view those files the user has to click the HTML+EEX link in the languages sidebar.

Ideally names within language groups would be combined in the link's search query but I'm not sure if GitHub's web search endpoints support this. Another idea is to have the most prevalent extension within the language group take precedence. So if I mostly have EEx templates in my repo, the "HTML" link would pass a l=html%2Beex query instead of l=html.

URL of the affected repository:

All repositories with files containing prefixed file extensions that are aggregated into language groups (.html.erb, .html.eex, etc.)

Last modified on:

2019-07-27

Expected language:

N/A

Detected language:

N/A

@pchaigno
Copy link
Contributor

pchaigno commented Jul 28, 2019

That's an old, known issue on GitHub's side :(

/cc @lildude

@lildude
Copy link
Member

lildude commented Jul 28, 2019

That's an old, known issue on GitHub NS side :(

Yup. Linguist is responsible for the grouping, but the main GitHub app is responsible for the search behaviour so not really something Linguist can control short of not grouping. As per the discussions in #4291 this would be a case where the grouping makes sense and isn't likely to change.

@lildude
Copy link
Member

lildude commented Aug 21, 2019

Closing as this isn't a problem with Linguist.

@lildude lildude closed this as completed Aug 21, 2019
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants