feat!: replace tslog by awspowertools logging #3037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npalm
changed the title
npalm
force-pushed
the
feat/awspowertools-logging
branch
from
2e45a92 to
f539cc7
Compare
modules/runner-binaries-syncer/lambdas/runner-binaries-syncer/src/logger/index.ts
Show resolved
Hide resolved
modules/runner-binaries-syncer/lambdas/runner-binaries-syncer/package.json
Show resolved
Hide resolved
GuptaNavdeep1983
previously approved these changes
Mar 16, 2023
replace logger by awslogger fix local.ts refactor and redact token in log
npalm
force-pushed
the
feat/awspowertools-logging
branch
from
2d8257a to
47337af
Compare
|
Tested the changes in this PR using default example and the logging changes are reflected in cloud watch log group. |
GuptaNavdeep1983
previously approved these changes
Mar 21, 2023
ScottGuymer
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module is using TSLog now for a sometime. But after breaking changes we are not able to update TSLog anymore. In the meantime, AWS have released AWS Powertools for Lambda, including logging capabilities. Since this solution is AWS native, we are replacing the outdated TSLog by AWS Powertools logging.
Breaking change
In this PR we replace TSLog by AWS Powertools logs with a minimal impact on code changes. The change can have be breaking in the following cases:
Log messages
All log messages are JSON formatted and contain besides the message scope information like:
function-name,environment,module. By enabling DEBUG log level the event received by the Lambda will be logged.