Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option for EBS Optimized? #2988

Closed
tedparagon opened this issue Feb 22, 2023 · 5 comments · Fixed by #3492
Closed

Option for EBS Optimized? #2988

tedparagon opened this issue Feb 22, 2023 · 5 comments · Fixed by #3492
Labels
abandoned Stale

Comments

@tedparagon
Copy link

I can't seem to find an option to enable EBS Optimized on the runner instance. Is this an oversight on my part or might there be a reason for not including this?

I believe this should just be a matter of setting ebs_optimized on the aws_launch_template.

Thanks!
@jpalomaki
Copy link
Contributor

@tedparagon I cannot see why we'd not want to support this. Can you post a PR to add the flag? See https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/launch_template#ebs_optimized

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2023

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Apr 9, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 19, 2023
@pbarnajc pbarnajc mentioned this issue Sep 21, 2023
Merged
npalm referenced this issue Sep 22, 2023
@pbarnajc @npalm
feat: Add ebs_optimized option (#3492)
bf73f1c 
Fixes:
https://github.com/philips-labs/terraform-aws-github-runner/issues/2988

Adds ebs_optimized parameter for ec2 instances.

Currently this defaults to false to keep it in line with the previous
behavior.

---------

Co-authored-by: Niek Palm <[email protected]>
@tedparagon
Copy link
Author

@pbarnajc thanks for adding this. I see ebs_optimized on the runners and multi-runners modules but don't see a way of setting it from the root module. I also can't find any mention of it in the docs.

@AlexShemeshWix
Copy link
Contributor

I can see the ebs_optimized on runners module. But how do i enable it on main module?

@AlexShemeshWix
Copy link
Contributor

@pbarnajc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
abandoned Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add ebs_optimized option pbarnajc/terraform-aws-github-runner
3 participants
@jpalomaki @AlexShemeshWix @tedparagon