Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add runner logfiles to output #2858

Merged
merged 5 commits into from
Jan 12, 2023
Merged

Conversation

sanketrathi
Copy link
Contributor

@sanketrathi sanketrathi commented Jan 9, 2023

This PR adds logfile information for runners to the module output

With this PR, we add propagate runners.logfiles out through the module
output. This would potentially enable module users to create CloudWatch
queries / metric filters (eg: runner startup time)

@npalm npalm self-requested a review January 10, 2023 15:27
Copy link
Collaborator

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Please can yo shortly describe the need for the output, would like to understand the problem you solving. In general ok, one small remark.

modules/multi-runner/outputs.tf Outdated Show resolved Hide resolved
@sanketrathi sanketrathi reopened this Jan 11, 2023
@sanketrathi sanketrathi requested a review from npalm January 11, 2023 17:25
modules/multi-runner/outputs.tf Outdated Show resolved Hide resolved
@npalm npalm merged commit a1013e9 into github-aws-runners:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants