Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag conflicting with Launch Template #2143

Closed
mcaulifn opened this issue Jun 10, 2022 · 3 comments · Fixed by #2182
Closed

Tag conflicting with Launch Template #2143

mcaulifn opened this issue Jun 10, 2022 · 3 comments · Fixed by #2182

Comments

@mcaulifn
Copy link
Contributor

mcaulifn commented Jun 10, 2022 •
edited
Loading

The generic Application tag is conflicting with a tag that we expect to use for cost reporting purposes. Any issues if we change this to something more specific like philips-labs:Application?

https://github.com/philips-labs/terraform-aws-github-runner/blob/56b2c3a98f67952b4b0df001f1b53fb486bca03d/modules/runners/lambdas/runners/src/aws/runners.ts#L161
@mcaulifn
Copy link
Contributor Author

Or we could create an environment variable for backward compatibility.

CC @npereiraexpedia @jeffj254

@mcaulifn
Copy link
Contributor Author

@npalm Any thoughts?

@npalm
Copy link
Collaborator

npalm commented Jun 22, 2022

Will have a look, added to my backlog

@npalm npalm closed this as completed Jun 22, 2022
@mcaulifn mcaulifn mentioned this issue Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(runners): Namespace Application tag mcaulifn/terraform-aws-github-runner
2 participants
@npalm @mcaulifn