Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GraphQL support #16

Open
gitfrosh opened this issue Oct 2, 2020 · 3 comments
Open

Add GraphQL support #16

gitfrosh opened this issue Oct 2, 2020 · 3 comments
Labels
enhancement New feature or request hacktoberfest

Comments

@gitfrosh
Copy link
Owner

gitfrosh commented Oct 2, 2020

Although REST is doing great for The one API, it would be nice to add and expose a GraphQL endpoint in the future.

Any help is appreciated. 🚀

@gitfrosh gitfrosh added the enhancement New feature or request label Oct 2, 2020
@WiLLiAM111333
Copy link

WiLLiAM111333 commented Nov 27, 2020

This might require some refactoring in your controllers and some helper functions to get all books as an example, are you sure you want this? Don't get me wrong I'd be happy to do it.

@WiLLiAM111333
Copy link

WiLLiAM111333 commented Nov 28, 2020

I've already started working on it, I'd be happy to change my strategy up if you dont like the small refactors in the PR coming sometime this week.

EDIT: I say we keep the authentication part full REST so we dont get any issues with graphql returning the hashed password as a url query param or something stupid

@gitfrosh
Copy link
Owner Author

Hey, just to make sure: I'd like to provide an additional / seperate GraphQL endpoint (maybe something like the-one-api.dev/v2/graphql/), that leaves the existing REST API spec as it is. Of course there might be some refactoring necessary. But if you came up with a first solution, you are welcome to set up a PR. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants