Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(l10n): bump Actions versions to avoid Node.js 16 deprecation warnings #749

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

dscho
Copy link

@dscho dscho commented Feb 11, 2024

This avoids the "Node.js 16 Actions are deprecated" warnings.

Since this workflow only runs in the l10n forks of git/git, it would be inappropriate to submit this patch to the Git mailing list for review, and I deem this the correct place to offer my contribution.

Copy link

Errors and warnings found by git-po-helper in workflow #534:

INFO no missing blobs of po/* in partial clone    
------------------------------------------------------------------------------
ERROR commit cd27b30: found changes beyond "po/" directory: 
ERROR 		.github/workflows/l10n.yml                 
ERROR                                              
ERROR commit cd27b30: break because this commit is not for git-l10n 
INFO checking commits: 0 passed, 1 failed.        
------------------------------------------------------------------------------
INFO downloading pot file from https://github.com/git-l10n/pot-changes/raw/pot/master/po/git.pot 

ERROR: fail to execute "git-po-helper check-commits"

@dscho
Copy link
Author

dscho commented Feb 11, 2024

ERROR commit cd27b30: found changes beyond "po/" directory:
ERROR .github/workflows/l10n.yml
ERROR
ERROR commit cd27b30: break because this commit is not for git-l10n

Umm. I would argue that this is for git-l10n... I guess that we'll need to change this condition?

dscho added a commit to dscho/git-po-helper that referenced this pull request Feb 11, 2024
…rship

The PR checks would otherwise fail if someone opens a PR to adjust the
l10n GitHub workflow, as I did over here:
git-l10n/git-po#749

Signed-off-by: Johannes Schindelin <[email protected]>
Copy link

Errors and warnings found by git-po-helper in workflow #535:

INFO no missing blobs of po/* in partial clone    
------------------------------------------------------------------------------
ERROR commit ac146fe: found changes beyond "po/" directory: 
ERROR 		.github/workflows/l10n.yml                 
ERROR                                              
ERROR commit ac146fe: break because this commit is not for git-l10n 
INFO checking commits: 0 passed, 1 failed, 1 skipped. 
------------------------------------------------------------------------------
INFO downloading pot file from https://github.com/git-l10n/pot-changes/raw/pot/master/po/git.pot 

ERROR: fail to execute "git-po-helper check-commits"

@dscho dscho marked this pull request as draft February 11, 2024 11:25
@dscho dscho changed the title build(deps): bump mshick/add-pr-comment actions/setup-go versions build(deps): bump mshick/add-pr-comment and actions/setup-go versions Feb 11, 2024
Copy link

Errors and warnings found by git-po-helper in workflow #536:

INFO no missing blobs of po/* in partial clone    
------------------------------------------------------------------------------
ERROR commit 88b8474: found changes beyond "po/" directory: 
ERROR 		.github/workflows/l10n.yml                 
ERROR                                              
ERROR commit 88b8474: break because this commit is not for git-l10n 
INFO checking commits: 0 passed, 1 failed, 2 skipped. 
------------------------------------------------------------------------------
INFO downloading pot file from https://github.com/git-l10n/pot-changes/raw/pot/master/po/git.pot 

ERROR: fail to execute "git-po-helper check-commits"

Copy link

Errors and warnings found by git-po-helper in workflow #538:

INFO no missing blobs of po/* in partial clone    
------------------------------------------------------------------------------
WARNING commit 1a9b204: subject length 57 > 50, about 63% commits have a subject less than 50 characters 
------------------------------------------------------------------------------
ERROR commit 1a9b204: subject ("fixup! TO-DROP: ...") does not have prefix "l10n:" 
------------------------------------------------------------------------------
ERROR commit 1a9b204: empty body of the commit message, no s-o-b signature 
------------------------------------------------------------------------------
ERROR commit 88b8474: found changes beyond "po/" directory: 
ERROR 		.github/workflows/l10n.yml                 
ERROR                                              
ERROR commit 88b8474: break because this commit is not for git-l10n 
INFO checking commits: 0 passed, 2 failed, 2 skipped. 
------------------------------------------------------------------------------
INFO downloading pot file from https://github.com/git-l10n/pot-changes/raw/pot/master/po/git.pot 

ERROR: fail to execute "git-po-helper check-commits"

Copy link

Errors and warnings found by git-po-helper in workflow #540:

INFO no missing blobs of po/* in partial clone    
------------------------------------------------------------------------------
WARNING commit 2f7aeed: subject length 57 > 50, about 63% commits have a subject less than 50 characters 
------------------------------------------------------------------------------
ERROR commit 2f7aeed: subject ("fixup! TO-DROP: ...") does not have prefix "l10n:" 
------------------------------------------------------------------------------
ERROR commit 2f7aeed: empty body of the commit message, no s-o-b signature 
------------------------------------------------------------------------------
WARNING commit 1a9b204: subject length 57 > 50, about 63% commits have a subject less than 50 characters 
------------------------------------------------------------------------------
ERROR commit 1a9b204: subject ("fixup! TO-DROP: ...") does not have prefix "l10n:" 
------------------------------------------------------------------------------
ERROR commit 1a9b204: empty body of the commit message, no s-o-b signature 
------------------------------------------------------------------------------
ERROR commit 88b8474: found changes beyond "po/" directory: 
ERROR 		.github/workflows/l10n.yml                 
ERROR                                              
ERROR commit 88b8474: break because this commit is not for git-l10n 
INFO checking commits: 0 passed, 3 failed, 2 skipped. 
------------------------------------------------------------------------------
INFO downloading pot file from https://github.com/git-l10n/pot-changes/raw/pot/master/po/git.pot 

ERROR: fail to execute "git-po-helper check-commits"

Copy link

Errors and warnings found by git-po-helper in workflow #542:

INFO no missing blobs of po/* in partial clone    
------------------------------------------------------------------------------
ERROR commit 477f22f: found changes beyond "po/" directory: 
ERROR 		.github/workflows/l10n.yml                 
ERROR                                              
ERROR commit 477f22f: break because this commit is not for git-l10n 
INFO checking commits: 0 passed, 1 failed, 5 skipped. 
------------------------------------------------------------------------------
INFO downloading pot file from https://github.com/git-l10n/pot-changes/raw/pot/master/po/git.pot 

ERROR: fail to execute "git-po-helper check-commits"

Copy link

Errors and warnings found by git-po-helper in workflow #544:

INFO no missing blobs of po/* in partial clone    
------------------------------------------------------------------------------
ERROR commit 9e9e642: found changes beyond "po/" directory: 
ERROR 		.github/workflows/l10n.yml                 
ERROR                                              
ERROR commit 9e9e642: break because this commit is not for git-l10n 
INFO checking commits: 0 passed, 1 failed, 6 skipped. 
------------------------------------------------------------------------------
INFO downloading pot file from https://github.com/git-l10n/pot-changes/raw/pot/master/po/git.pot 

ERROR: fail to execute "git-po-helper check-commits"

Copy link

Errors and warnings found by git-po-helper in workflow #546:

INFO no missing blobs of po/* in partial clone    
------------------------------------------------------------------------------
ERROR commit c5f67b5: found changes beyond "po/" directory: 
ERROR 		.github/workflows/l10n.yml                 
ERROR                                              
ERROR commit c5f67b5: break because this commit is not for git-l10n 
INFO checking commits: 0 passed, 1 failed, 1 skipped. 
------------------------------------------------------------------------------
INFO downloading pot file from https://github.com/git-l10n/pot-changes/raw/pot/master/po/git.pot 

ERROR: fail to execute "git-po-helper check-commits"

@dscho dscho force-pushed the l10n-actions-updates branch from c5f67b5 to ef79263 Compare February 11, 2024 11:45
Copy link

Errors and warnings found by git-po-helper in workflow #548:

INFO no missing blobs of po/* in partial clone    
------------------------------------------------------------------------------
ERROR commit ef79263: found changes beyond "po/" directory: 
ERROR 		.github/workflows/l10n.yml                 
ERROR                                              
ERROR commit ef79263: break because this commit is not for git-l10n 
INFO checking commits: 0 passed, 1 failed, 1 skipped. 
------------------------------------------------------------------------------
INFO downloading pot file from https://github.com/git-l10n/pot-changes/raw/pot/master/po/git.pot 

ERROR: fail to execute "git-po-helper check-commits"

This avoids the "Node.js 16 Actions are deprecated" warnings.

Original-commits-by: dependabot[bot] <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho force-pushed the l10n-actions-updates branch from ef79263 to 14a4f26 Compare February 11, 2024 11:49
Copy link

Errors and warnings found by git-po-helper in workflow #550:

INFO no missing blobs of po/* in partial clone    
------------------------------------------------------------------------------
ERROR commit 14a4f26: found changes beyond "po/" directory: 
ERROR 		.github/workflows/l10n.yml                 
ERROR                                              
ERROR commit 14a4f26: break because this commit is not for git-l10n 
INFO checking commits: 0 passed, 1 failed, 1 skipped. 
------------------------------------------------------------------------------
INFO downloading pot file from https://github.com/git-l10n/pot-changes/raw/pot/master/po/git.pot 

ERROR: fail to execute "git-po-helper check-commits"

@dscho
Copy link
Author

dscho commented Feb 11, 2024

This PR requires git-l10n/git-po-helper#18 to be merged first, to avoid all those incorrect git-po-helper CI failures.

@dscho dscho changed the title build(deps): bump mshick/add-pr-comment and actions/setup-go versions ci(l10n): bump Actions versions to avoid Node.js 16 deprecation warnings Feb 11, 2024
@dscho dscho force-pushed the l10n-actions-updates branch from 14a4f26 to 6032aee Compare February 12, 2024 15:16
@dscho dscho marked this pull request as ready for review February 12, 2024 15:17
@dscho
Copy link
Author

dscho commented Feb 12, 2024

@jiangxin please review.

@jiangxin
Copy link
Member

LGTM, will merge.

@jiangxin jiangxin merged commit 6032aee into git-l10n:master Feb 13, 2024
2 checks passed
@dscho dscho deleted the l10n-actions-updates branch February 13, 2024 18:39
@jiangxin
Copy link
Member

jiangxin commented Feb 16, 2024

Please help to review pull request #757 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants