Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop pretending that the l10n.yml workflow is outside git-l10n's ownership #18

Merged

Conversation

dscho
Copy link
Contributor

@dscho dscho commented Feb 11, 2024

The PR checks would otherwise fail if someone opens a PR to adjust the l10n GitHub workflow, as I did over here:
git-l10n/git-po#749

…rship

The PR checks would otherwise fail if someone opens a PR to adjust the
l10n GitHub workflow, as I did over here:
git-l10n/git-po#749

Signed-off-by: Johannes Schindelin <[email protected]>
@jiangxin
Copy link
Member

In order to test GitHub Actions for git-l10n and test some git-l10n changes, developers may want to change the workflow (i.e. .github/workflows/l10n.yml) in the default branch of their own repositories. But git-po-helper fails to run because the changes on ".github/workflows/l10n.yml" are outside of po/ directory.

Will merge this change. Please note that changes on ".github/workflows/l10n.yml" should be contributed to git through the normal workflow, i.e. sending patches to the Git mailing list.

@jiangxin jiangxin merged commit 254081f into git-l10n:main Feb 12, 2024
3 checks passed
@dscho dscho deleted the l10n-github-workflow-is-owned-by-git-l10n branch February 12, 2024 05:48
@dscho
Copy link
Contributor Author

dscho commented Feb 12, 2024

Please note that changes on ".github/workflows/l10n.yml" should be contributed to git through the normal workflow, i.e. sending patches to the Git mailing list.

I would like to suggest that git-po is the appropriate repository for that PR: That is where the workflow runs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants