Weekly Digest (13 October, 2019 - 20 October, 2019)

[weekly-digest]

Here's the Weekly Digest for git-for-windows/git:

---

ISSUES

Last week 7 issues were created.
Of these, 4 issues have been closed and 3 issues are still open.

OPEN ISSUES

💚 #2361 Could not access submodule when pulling recursively with git 2.22.0.windows.1, by agmikhailov
💚 #2360 Rebase to v2.24.0-rc0, by dscho
💚 #2357 git-bash: document the Windows initiator program, by PhilipOakley

CLOSED ISSUES

❤️ #2362 Revert "A couple of fixups for add-i-in-c-status-and-help", by ESA-Security-Group
❤️ #2359 Work around that pesky Homebrew perforce problem, by dscho
❤️ #2358 Make git config --system work like you think it should on Windows, by dscho
❤️ #2356 Shears/next, by gsiteiovn

LIKED ISSUE

👍 #2358 Make git config --system work like you think it should on Windows, by dscho
It received 👍 x1, 😄 x0, 🎉 x0 and ❤️ x1.

NOISY ISSUE

🔈 #2358 Make git config --system work like you think it should on Windows, by dscho
It received 11 comments.

---

PULL REQUESTS

Last week, 5 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 3 pull requests were updated.
💛 #2360 Rebase to v2.24.0-rc0, by dscho
💛 #2357 git-bash: document the Windows initiator program, by PhilipOakley
💛 #1604 Improve handling of commands in Git.pm on native Windows, by ColMelvin

MERGED PULL REQUEST

Last week, 2 pull requests were merged.
💜 #2359 Work around that pesky Homebrew perforce problem, by dscho
💜 #2358 Make git config --system work like you think it should on Windows, by dscho

---

COMMITS

Last week there were 6 commits.
🛠️ Merge pull request #2358 from dscho/reconcile-system-config-and-programdata-config Make git config --system work like you think it should on Windows by dscho
🛠️ Merge pull request #2359 from dscho/homebrew-perforce Work around that pesky Homebrew perforce problem by dscho
🛠️ fixup! ci(osx): use new location of the perforce cask It still fails! Still! Even after upgrading the cask's definition in the PR https://github.com/Homebrew/homebrew-cask/pull/70981 does it fail. The explanation is, as Gábor Szeder dug out from the commit history: the local definitions might get stale and need to be updated. So let's just update them in case brew cask install perforce fails, and just try again! This will still fail, of course, when homebrew-cask falls behind Perforce's release schedule. But once it is updated, we can now simply re-run the failed jobs and they will pick up that update. As to updating homebrew-cask: I started automating this, via https://dev.azure.com/gitgitgadget/git/_build?definitionId=11&_a=summary (I plan on finishing it once the next Perforce upgrade comes around.) Signed-off-by: Johannes Schindelin [email protected] by dscho
🛠️ fixup! Windows: add support for a Windows-wide configuration In the previous commit, we moved the location of the system config to C:\Program Files\Git\etc\gitconfig, to give users a reliable location for the system config. Previously, we had introduced C:\ProgramData\Git\config as such a location. However, the purpose of C:\ProgramData\Git\config was always for the installed Git for Windows to share its configured options. Every upgrade will modify the settings in that file according to what the user specified when running Git for Windows' installer. So it is not really a file whose ownership is shared between all Git implementations, contrary to what the location suggests. Also, it was totally confusing to many users that there was a "system" config and then yet another "sort of system" config that did not even have a corresponding git config option such as --system. Further, Portable Git should probably never look at C:\ProgramData\Git\config to begin with: this makes it rather non-Portable ;-) Finally, support for C:\ProgramData\Git\config never really caught on: only libgit2 implemented it, but even JGit (which might be used by more users than libgit2-based applications by grace of backing Android Studio) did not. Therefore, let's finally admit that it was a mistake to introduce C:\ProgramData\Git\config and remove support for it. This reverts commit bcbbb4f89f57cdd6d2260d28b274e9e6334d7ed3. Signed-off-by: Johannes Schindelin [email protected] by dscho
🛠️ ci(osx): use new location of the perforce cask The CI builds are failing for Mac OS X due to a change in the location of the perforce cask. The command outputs the following error: + brew install caskroom/cask/perforce Error: caskroom/cask was moved. Tap homebrew/cask-cask instead. Preface the "brew install caskroom/cask/perforce" with the old way of installing perforce, and only try this method if the "brew install perforce" fails. The existing way to use caskroom was added in 672f51cb (travis-ci: fix Perforce install on macOS, 2017-01-22) and the justification is that the "brew install perforce" can fail due to a hash mis-match. The mismatch is due to the official Perforce distro updating the published binaries without updating the version string. CI servers are typically fresh virtual machines, so that issue should not arise in automated builds. Even if a build server is re-used and hits the hash mis-match, it will fall back to the "new" mechanism which is currently failing, but may be fixed independently of this change. Signed-off-by: Johannes Schindelin [email protected] Signed-off-by: Derrick Stolee [email protected] by dscho
🛠️ mingw: prepare for making git config --system do what users expect This moves the system config into a more logical location: the mingw64 part of C:\Program Files\Git\mingw64\etc\gitconfig never made sense, as it is a mere implementation detail. Let's skip the mingw64 part and move this to C:\Program Files\Git\etc\gitconfig. Side note: in the rare (and not recommended) case a user chooses to install 32-bit Git for Windows on a 64-bit system, the path will of course be C:\Program Files (x86)\Git\etc\gitconfig. The next step after this patch is to scrap support for C:\ProgramData\Git\config, which never really made sense to users, and which is inconsistent with non-Windows versions of Git, anyway. Background: During the Git for Windows v1.x days, the system config was located at C:\Program Files (x86)\Git\etc\gitconfig. With Git for Windows v2.x, it moved to C:\Program Files\Git\mingw64\gitconfig (or C:\Program Files (x86)\Git\mingw32\gitconfig). Obviously, this new location was not stable (because of the "mingw64" part) and this maintainer thought that it was a splendid time to introduce a "super-system" config, with a constant location, that would be shared by all Git implementations. Hence C:\ProgramData\Git\config was born. What we should have done instead is to move the location to the top-level etc directory instead of the mingw64\etc one (or mingw32\etc for 32-bit versions). Likewise, we should have treated the system gitattributes in a similar manner. This patch makes it so. Obviously, we are cautious to do this only for the known install locations /mingw64 and /mingw32; If anybody wants to override that while building their version of Git (e.g. via make prefix=$HOME), we leave the default location of the system config and gitattributes alone. Signed-off-by: Johannes Schindelin [email protected] by dscho

---

CONTRIBUTORS

Last week there was 1 contributor.
👤 dscho

---

STARGAZERS

Last week there were 8 stagazers.
⭐ gefrier
⭐ jgabrielgv
⭐ windqyoung
⭐ vvcln
⭐ hbchue
⭐ cancan626
⭐ sapk
⭐ axifive
You all are the stars! 🌟

---

RELEASES

Last week there were no releases.

---

That's all for last week, please 👀 Watch and ⭐ Star the repository git-for-windows/git to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆