Prepare for uploading Pacman packages targeting Windows/ARM64 #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `push` and `push_missing_signatures`, we need to skip sources for architectures other than x86_64, and MINGW packages for other architectures than the current one. The logic worked, but was convoluted, and unnecessarily verbose. Let's fix this, and at the same time future-proof the code: We are about to introduce support for packages targeting Windows/ARM64. Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
We do not have any official packages in Git for Windows targeting Windows/ARM64 yet. But this is about to change. This commit is best viewed with `-w`. Signed-off-by: Johannes Schindelin <[email protected]>
dennisameling
approved these changes
Dec 22, 2022
@dennisameling ideally, I would like to see git-for-windows/git-for-windows-automation#5 and git-for-windows/git-for-windows-automation#4 merged, and then build a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be enough to get that part of the deployment working. The idea is that we will have two new package indices, a full one and a MINGW-only one. Until the time when Cygwin starts supporting Windows/ARM64, these will contain the same set of packages.
The idea is that we can then set up
/etc/pacman.confingit-sdk-arm64to contain these lines: