Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store oauth_refresh_token #1463

Open
hickford opened this issue Nov 3, 2023 · 0 comments · May be fixed by #1464
Open

Store oauth_refresh_token #1463

hickford opened this issue Nov 3, 2023 · 0 comments · May be fixed by #1464
Labels
auth:oauth Specific to OAuth2 authentication enhancement New feature or request

Comments

@hickford
Copy link
Contributor

hickford commented Nov 3, 2023

It would be useful to store Git credential attribute oauth_refresh_token

Currently GitLabHostProvider, BitBucketHostProvider and GenericHostProvider use a hacky workaround to save oauth_refresh_token as the password for a separate service:

git-credential-manager/src/shared/GitLab/GitLabHostProvider.cs

Lines 218 to 219 in 2365cac

// store refresh token under a separate service
Context.CredentialStore.AddOrUpdate(refreshService, oAuthCredential.Account, oAuthCredential.RefreshToken);

@hickford hickford linked a pull request Nov 3, 2023 that will close this issue
Open
@mjcheetham mjcheetham added enhancement New feature or request auth:oauth Specific to OAuth2 authentication labels Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auth:oauth Specific to OAuth2 authentication enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Store PasswordExpiry and OAuthRefreshToken hickford/git-credential-manager
2 participants
@hickford @mjcheetham