Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: v2.3.0 #1626

Merged
merged 8 commits into from
Jul 1, 2023
Merged

common: v2.3.0 #1626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aa8c61c
common: Update types for available languages and themes
laymonage Jul 1, 2023
e3613a2
svelte: Enable prettier-plugin-svelte strict mode and reformat code
laymonage Jul 1, 2023
ef2ac60
svelte: Fix incorrect types path
laymonage Jul 1, 2023
15b6a2b
svelte: Add Svelte 4 support
laymonage Jul 1, 2023
cd70036
web: Ensure host is never empty when accessed
laymonage Jul 1, 2023
0e44e65
web: Ensure custom element is only registered once
laymonage Jul 1, 2023
935ebc8
web: Bump to 1.3.0
laymonage Jul 1, 2023
615411c
common: Update giscus to 1.3.0 and bump version to 2.3.0
laymonage Jul 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .prettierrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"useTabs": false,
"singleQuote": true,
"trailingComma": "es5",
"printWidth": 80
"printWidth": 80,
"svelteStrictMode": true
}
22 changes: 11 additions & 11 deletions react/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@giscus/react",
"version": "2.2.8",
"version": "2.3.0",
"main": "dist/index.js",
"module": "dist/wrapper.mjs",
"types": "dist/index.d.ts",
Expand Down Expand Up @@ -29,7 +29,7 @@
"format:fix": "prettier src --write"
},
"dependencies": {
"giscus": "^1.2.8"
"giscus": "^1.3.0"
},
"peerDependencies": {
"react": "^16 || ^17 || ^18",
Expand Down
12 changes: 10 additions & 2 deletions react/src/lib/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,23 @@ export type Theme =
| 'dark_protanopia'
| 'dark_tritanopia'
| 'dark_dimmed'
| 'transparent_dark'
| 'preferred_color_scheme'
| 'transparent_dark'
| 'noborder_light'
| 'noborder_dark'
| 'cobalt'
| `https://${string}`
| GenericString;

export type AvailableLanguage =
| 'ar'
| 'ca'
| 'de'
| 'gsw'
| 'en'
| 'es'
| 'fa'
| 'fr'
| 'he'
| 'id'
| 'it'
| 'ja'
Expand All @@ -44,8 +50,10 @@ export type AvailableLanguage =
| 'pt'
| 'ro'
| 'ru'
| 'th'
| 'tr'
| 'vi'
| 'uk'
| 'zh-CN'
| 'zh-TW'
| GenericString;
Expand Down
22 changes: 11 additions & 11 deletions solid/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions solid/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@giscus/solid",
"version": "2.2.8",
"version": "2.3.0",
"main": "dist/index.js",
"module": "dist/wrapper.mjs",
"types": "dist/index.d.ts",
Expand Down Expand Up @@ -29,7 +29,7 @@
"format:fix": "prettier src --write"
},
"dependencies": {
"giscus": "^1.2.8"
"giscus": "^1.3.0"
},
"peerDependencies": {
"solid-js": "^1.3 || ^1.4 || ^1.5 || ^1.6"
Expand Down
12 changes: 10 additions & 2 deletions solid/src/lib/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,23 @@ export type Theme =
| 'dark_protanopia'
| 'dark_tritanopia'
| 'dark_dimmed'
| 'transparent_dark'
| 'preferred_color_scheme'
| 'transparent_dark'
| 'noborder_light'
| 'noborder_dark'
| 'cobalt'
| `https://${string}`
| GenericString;

export type AvailableLanguage =
| 'ar'
| 'ca'
| 'de'
| 'gsw'
| 'en'
| 'es'
| 'fa'
| 'fr'
| 'he'
| 'id'
| 'it'
| 'ja'
Expand All @@ -44,8 +50,10 @@ export type AvailableLanguage =
| 'pt'
| 'ro'
| 'ru'
| 'th'
| 'tr'
| 'vi'
| 'uk'
| 'zh-CN'
| 'zh-TW'
| GenericString;
Expand Down
24 changes: 12 additions & 12 deletions svelte/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions svelte/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"name": "@giscus/svelte",
"version": "2.2.8",
"types": "./index.d.ts",
"version": "2.3.0",
"repository": {
"type": "git",
"url": "https://github.com/giscus/giscus-component.git",
Expand Down Expand Up @@ -38,10 +37,10 @@
},
"type": "module",
"dependencies": {
"giscus": "^1.2.8"
"giscus": "^1.3.0"
},
"peerDependencies": {
"svelte": "^3"
"svelte": "^3 || ^4"
},
"exports": {
"./package.json": "./package.json",
Expand All @@ -61,5 +60,6 @@
"files": [
"package"
],
"svelte": "./package/index.js"
"svelte": "./package/index.js",
"types": "./package/index.d.ts"
}
31 changes: 15 additions & 16 deletions svelte/src/lib/Giscus.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,20 +35,19 @@

{#if mounted}
<giscus-widget
{id}
{host}
{repo}
repoid={repoId}
{category}
categoryid={categoryId}
{mapping}
{term}
{strict}
reactionsenabled={reactionsEnabled}
emitmetadata={emitMetadata}
inputposition={inputPosition}
{theme}
{lang}
{loading}
/>
id="{id}"
host="{host}"
repo="{repo}"
repoid="{repoId}"
category="{category}"
categoryid="{categoryId}"
mapping="{mapping}"
term="{term}"
strict="{strict}"
reactionsenabled="{reactionsEnabled}"
emitmetadata="{emitMetadata}"
inputposition="{inputPosition}"
theme="{theme}"
lang="{lang}"
loading="{loading}"></giscus-widget>
{/if}
12 changes: 10 additions & 2 deletions svelte/src/lib/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,23 @@ export type Theme =
| 'dark_protanopia'
| 'dark_tritanopia'
| 'dark_dimmed'
| 'transparent_dark'
| 'preferred_color_scheme'
| 'transparent_dark'
| 'noborder_light'
| 'noborder_dark'
| 'cobalt'
| `https://${string}`
| GenericString;

export type AvailableLanguage =
| 'ar'
| 'ca'
| 'de'
| 'gsw'
| 'en'
| 'es'
| 'fa'
| 'fr'
| 'he'
| 'id'
| 'it'
| 'ja'
Expand All @@ -44,8 +50,10 @@ export type AvailableLanguage =
| 'pt'
| 'ro'
| 'ru'
| 'th'
| 'tr'
| 'vi'
| 'uk'
| 'zh-CN'
| 'zh-TW'
| GenericString;
Expand Down
Loading