Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New host property is sometimes blank in Vue SPA #572

Closed
davidmyersdev opened this issue Sep 11, 2022 · 0 comments · Fixed by #754
Closed

New host property is sometimes blank in Vue SPA #572

davidmyersdev opened this issue Sep 11, 2022 · 0 comments · Fixed by #754

Comments

@davidmyersdev
Copy link

I am using Giscus with Nuxt 3. After updating the @giscus/vue package, the host property (which I do not pass to the component) sometimes resolves to an empty string instead of https://giscus.app. From what I can tell, this only happens when jumping between pages using client-side navigation. When a page is loaded directly (reloading a page that has the Giscus component on it already), it loads fine. Manually specifying https://giscus.app as the host fixes the problem for now, but I think this is an unexpected regression.

@laymonage laymonage mentioned this issue Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant